Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move C++ code to OSS folders #36788

Closed
wants to merge 1 commit into from

Conversation

luluwu2032
Copy link
Contributor

Summary:
Move

xplat/ReactNative/venice/hermes

to

xplat/js/react-native-github/packages/react-native/ReactCommon/react/bridgeless/hermes

Changelog:
[General][Changed] - Move Bridgeless C++ code to OSS folders

Differential Revision: D44501429

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Apr 4, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44501429

@analysis-bot
Copy link

analysis-bot commented Apr 4, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,620,473 +0
android hermes armeabi-v7a 7,933,152 +0
android hermes x86 9,106,476 +0
android hermes x86_64 8,961,275 +0
android jsc arm64-v8a 9,186,853 +0
android jsc armeabi-v7a 8,377,153 +0
android jsc x86 9,244,447 +0
android jsc x86_64 9,502,930 +0

Base commit: 7495883
Branch: main

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44501429

luluwu2032 pushed a commit to luluwu2032/react-native that referenced this pull request Apr 18, 2023
Summary:
Pull Request resolved: facebook#36788

Move
> xplat/ReactNative/venice/hermes

to

> xplat/js/react-native-github/packages/react-native/ReactCommon/react/bridgeless/hermes

Changelog:
[General][Changed] - Move Bridgeless C++ code to OSS folders

Reviewed By: cortinico

Differential Revision: D44501429

fbshipit-source-id: 3b0a1c07de01cd217d35b4c2561ba0676bef081f
luluwu2032 pushed a commit to luluwu2032/react-native that referenced this pull request Apr 18, 2023
Summary:
Pull Request resolved: facebook#36788

Move
> xplat/ReactNative/venice/hermes

to

> xplat/js/react-native-github/packages/react-native/ReactCommon/react/bridgeless/hermes

Changelog:
[General][Changed] - Move Bridgeless C++ code to OSS folders

Reviewed By: cortinico

Differential Revision: D44501429

fbshipit-source-id: c5c6a9fc041c7900857eb791ae697bfa05355278
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44501429

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44501429

luluwu2032 pushed a commit to luluwu2032/react-native that referenced this pull request Apr 18, 2023
Summary:
Pull Request resolved: facebook#36788

Move
> xplat/ReactNative/venice/hermes

to

> xplat/js/react-native-github/packages/react-native/ReactCommon/react/bridgeless/hermes

Changelog:
[General][Changed] - Move Bridgeless C++ code to OSS folders

Reviewed By: cortinico

Differential Revision: D44501429

fbshipit-source-id: 9024dd932468f5fd59bdfe251be083b250ae5c47
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44501429

luluwu2032 pushed a commit to luluwu2032/react-native that referenced this pull request Apr 18, 2023
Summary:
Pull Request resolved: facebook#36788

Move
> xplat/ReactNative/venice/hermes

to

> xplat/js/react-native-github/packages/react-native/ReactCommon/react/bridgeless/hermes

Changelog:
[General][Changed] - Move Bridgeless C++ code to OSS folders

Reviewed By: cortinico

Differential Revision: D44501429

fbshipit-source-id: bcf6bef822b4157320ef2ed22412e9d0d8ebd782
Summary:
Pull Request resolved: facebook#36788

Move
> xplat/ReactNative/venice/hermes

to

> xplat/js/react-native-github/packages/react-native/ReactCommon/react/bridgeless/hermes

Changelog:
[General][Changed] - Move Bridgeless C++ code to OSS folders

Reviewed By: cortinico

Differential Revision: D44501429

fbshipit-source-id: 50972a10f90dd0571063e26aeb8020c7b6419f1c
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44501429

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Apr 18, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in e6177d6.

jeongshin pushed a commit to jeongshin/react-native that referenced this pull request May 7, 2023
Summary:
Pull Request resolved: facebook#36788

Move
> xplat/ReactNative/venice/hermes

to

> xplat/js/react-native-github/packages/react-native/ReactCommon/react/bridgeless/hermes

Changelog:
[General][Changed] - Move Bridgeless C++ code to OSS folders

Reviewed By: cortinico

Differential Revision: D44501429

fbshipit-source-id: 5a63fe53dd4e1f3906fc9a1011114b53a6549caf
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
Summary:
Pull Request resolved: facebook#36788

Move
> xplat/ReactNative/venice/hermes

to

> xplat/js/react-native-github/packages/react-native/ReactCommon/react/bridgeless/hermes

Changelog:
[General][Changed] - Move Bridgeless C++ code to OSS folders

Reviewed By: cortinico

Differential Revision: D44501429

fbshipit-source-id: 5a63fe53dd4e1f3906fc9a1011114b53a6549caf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants