Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metro-config): fix and realign the situation for metro config for 0.72 #36746

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

kelset
Copy link
Contributor

@kelset kelset commented Mar 31, 2023

Summary:

As noted by @hoxyq here there's some inconsistencies with what happened with metro config and its releases.

Basically, it looks like 0.72.1 of metro-config was released from main branch instead of 0.72-stable, which means that currently 0.72 is in an inconsistent state for its package.

Relevant commits:

It shouldn't be too big of a deal, and this PR should realign the situation so that the metro-config folder in 0.72-stable is exactly the same as main (and future 0.72.x releases of metro-config will need to happen from this branch, while main is on 0.73.x now).

Because I'm doing it this way, CI won't trigger and won't attempt to re-release 0.72.1 of metro-config.

Changelog:

[INTERNAL] [FIXED] - fix and realign the situation for metro config for 0.72

Test Plan:

N/A

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 31, 2023
@kelset kelset requested a review from cipolleschi March 31, 2023 16:28
@facebook-github-bot facebook-github-bot added Contributor A React Native contributor. p: Microsoft Partner: Microsoft Partner labels Mar 31, 2023
@kelset kelset requested review from huntie and hoxyq March 31, 2023 16:28
@github-actions
Copy link

Warnings
⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against 27f9096

Copy link
Member

@huntie huntie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching the detail about the incremented version. Would've read from npm but not from the local monorepo copy 👍. Only the template needs the new API from ^0.72.1.

@kelset kelset merged commit e795b53 into 0.72-stable Mar 31, 2023
@kelset kelset deleted the kelset/fix-072-metro-config branch March 31, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. p: Microsoft Partner: Microsoft Partner Pick Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants