[Codegen 96-97] Extract throwIfConfigNotfound and throwIfMoreThanOneConfig from findComponentConfig function #36719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
AntoineDoubovetzky
force-pushed
the
refactor/extract-errors-from-findComponentConfig
branch
from
3ad8427 to
f383b6e
Compare
cipolleschi
approved these changes
Mar 30, 2023
cipolleschi
requested changes
Mar 30, 2023
packages/react-native-codegen/src/parsers/__tests__/error-utils-test.js
Outdated
Show resolved
Hide resolved
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
AntoineDoubovetzky
force-pushed
the
refactor/extract-errors-from-findComponentConfig
branch
2 times, most recently
from
736a2f7 to
810b213
Compare
Base commit: 28dac61 |
|
@cipolleschi It should be good now |
|
/rebase |
github-actions
bot
force-pushed
the
refactor/extract-errors-from-findComponentConfig
branch
from
810b213 to
6ea17c8
Compare
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
/rebase |
github-actions
bot
force-pushed
the
refactor/extract-errors-from-findComponentConfig
branch
from
6ea17c8 to
33568f4
Compare
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cipolleschi
approved these changes
Apr 5, 2023
|
/rebase |
|
I don't know why automatic rebase stopped working. While we work on this, could you pleas rebase manually? 🙏 |
|
@cipolleschi merged this pull request in 8fbcfce. |
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
…omponentConfig function (facebook#36719) Summary: This PR contains tasks 96 and 97 from facebook#34872: >[Codegen 96 - assigned to AntoineDoubovetzky] Create a throwIfConfigNotfound in the error-utils.js file and extract the error code from [Flow](https://github.com/facebook/react-native/blob/main/packages/react-native-codegen/src/parsers/flow/components/index.js#L61-L63) and [TS](https://github.com/facebook/react-native/blob/main/packages/react-native-codegen/src/parsers/typescript/components/index.js#L62-L64) [Codegen 97 - assigned to AntoineDoubovetzky] Create a throwIfMoreThanOneConfig in the error-utils.js file and extract the error code from [Flow](https://github.com/facebook/react-native/blob/main/packages/react-native-codegen/src/parsers/flow/components/index.js#L64-L66) and [TS](https://github.com/facebook/react-native/blob/main/packages/react-native-codegen/src/parsers/typescript/components/index.js#L65-L67) ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [Internal] [Changed] - Extract throwIfConfigNotfound and throwIfMoreThanOneConfig from findComponentConfig function bypass-github-export-checks Pull Request resolved: facebook#36719 Test Plan: I tested using Jest and Flow commands. Reviewed By: rshest Differential Revision: D44539681 Pulled By: cipolleschi fbshipit-source-id: c778ad1620d1c3f60b10c25c51efcb11173b3037
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
…omponentConfig function (facebook#36719) Summary: This PR contains tasks 96 and 97 from facebook#34872: >[Codegen 96 - assigned to AntoineDoubovetzky] Create a throwIfConfigNotfound in the error-utils.js file and extract the error code from [Flow](https://github.com/facebook/react-native/blob/main/packages/react-native-codegen/src/parsers/flow/components/index.js#L61-L63) and [TS](https://github.com/facebook/react-native/blob/main/packages/react-native-codegen/src/parsers/typescript/components/index.js#L62-L64) [Codegen 97 - assigned to AntoineDoubovetzky] Create a throwIfMoreThanOneConfig in the error-utils.js file and extract the error code from [Flow](https://github.com/facebook/react-native/blob/main/packages/react-native-codegen/src/parsers/flow/components/index.js#L64-L66) and [TS](https://github.com/facebook/react-native/blob/main/packages/react-native-codegen/src/parsers/typescript/components/index.js#L65-L67) ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [Internal] [Changed] - Extract throwIfConfigNotfound and throwIfMoreThanOneConfig from findComponentConfig function bypass-github-export-checks Pull Request resolved: facebook#36719 Test Plan: I tested using Jest and Flow commands. Reviewed By: rshest Differential Revision: D44539681 Pulled By: cipolleschi fbshipit-source-id: c778ad1620d1c3f60b10c25c51efcb11173b3037
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR contains tasks 96 and 97 from #34872:
Changelog:
[Internal] [Changed] - Extract throwIfConfigNotfound and throwIfMoreThanOneConfig from findComponentConfig function
Test Plan:
I tested using Jest and Flow commands.