Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make setJSEngineResolutionAlgorithm a public method #36715

Closed
wants to merge 2 commits into from
Closed

Make setJSEngineResolutionAlgorithm a public method #36715

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5882beb
make the setter function public (#6)
SparshaSaha Mar 30, 2023
54ef724
Merge branch 'facebook:main' into main
SparshaSaha Mar 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...act-native/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManagerBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ public ReactInstanceManagerBuilder setJSBundleLoader(JSBundleLoader jsBundleLoad
* Sets the JS Engine to load as either Hermes or JSC. If not set, the default is JSC with a
* Hermes fallback.
*/
private void setJSEngineResolutionAlgorithm(
public void setJSEngineResolutionAlgorithm(
@Nullable JSEngineResolutionAlgorithm jsEngineResolutionAlgorithm) {
this.jsEngineResolutionAlgorithm = jsEngineResolutionAlgorithm;
}
Expand Down