Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] [Breaking] Fix compilation errors caused by the "module" keyword becoming a rese… #36701

Closed
wants to merge 1 commit into from
Closed

[iOS] [Breaking] Fix compilation errors caused by the "module" keyword becoming a rese… #36701

wants to merge 1 commit into from

Conversation

CrazyFanFan
Copy link

@CrazyFanFan CrazyFanFan commented Mar 29, 2023

Fix issue #36700

Summary

Fix compilation errors caused by the "module" keyword becoming a reserved keyword.

This is a breaking change commit.
RCTBridgeMethod 's public api:

  • (id)invokeWithBridge:(RCTBridge *)bridge module:(id)module arguments:(NSArray *)arguments;
    renamed to :
  • (id)invokeWithBridge:(RCTBridge *)bridge bridgeModule:(id)bridgeModule arguments:(NSArray *)arguments;

@facebook-github-bot
Copy link
Contributor

Hi @CrazyFanFan!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@github-actions
Copy link

github-actions bot commented Mar 29, 2023

Fails
🚫

📋 Missing Changelog - Please add a Changelog to your PR description. See Changelog format

Warnings
⚠️ 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against afc9f22

@CrazyFanFan
Copy link
Author

This is a breaking change commit.
RCTBridgeMethod 's public api:
- (id)invokeWithBridge:(RCTBridge *)bridge module:(id)module arguments:(NSArray *)arguments;
renamed to :
- (id)invokeWithBridge:(RCTBridge *)bridge bridgeModule:(id)bridgeModule arguments:(NSArray *)arguments;

@CrazyFanFan CrazyFanFan changed the title Fix compilation errors caused by the "module" keyword becoming a rese… [iOS] [Breaking] Fix compilation errors caused by the "module" keyword becoming a rese… Mar 29, 2023
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,546,164 -500
android hermes armeabi-v7a 7,860,694 -483
android hermes x86 9,027,469 -496
android hermes x86_64 8,883,152 -501
android jsc arm64-v8a 9,166,773 -337
android jsc armeabi-v7a 8,357,330 -320
android jsc x86 9,222,855 -317
android jsc x86_64 9,481,336 -331

Base commit: c1c22eb
Branch: main

@react-native-bot react-native-bot added the No CLA Authors need to sign the CLA before a PR can be reviewed. label Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No CLA Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants