Convert the app template to Kotlin #36696
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D44142081 |
Base commit: e17385a |
Summary: Pull Request resolved: facebook#36696 As the title says, we're converting the new app template to Kotlin. This will reduce the template size and make it more aligned to market standards. Changelog: [Android] [Changed] - Convert the app template to Kotlin Reviewed By: mdvacca Differential Revision: D44142081 fbshipit-source-id: 71ad604b00baad6822657edb2460149849703b94
|
This pull request was exported from Phabricator. Differential Revision: D44142081 |
cortinico
force-pushed
the
export-D44142081
branch
from
c94ee72 to
0343f54
Compare
|
This pull request has been merged in c1c22eb. |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Mar 29, 2023
Summary: Following up to facebook#36696, I accidentally failed a rebase and had files commited on the wrong folder. I'm updating them here to use `packages/react-native/template`. Changelog: [Internal] [Changed] - Move from from accidental template/ folder on root Reviewed By: cipolleschi Differential Revision: D44502966 fbshipit-source-id: 57b2116e9048808a5a564a91274508ef2262273e
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Mar 29, 2023
Summary: Pull Request resolved: facebook#36704 Following up to facebook#36696, I accidentally failed a rebase and had files commited on the wrong folder. I'm updating them here to use `packages/react-native/template`. Changelog: [Internal] [Changed] - Move from from accidental template/ folder on root Reviewed By: cipolleschi Differential Revision: D44502966 fbshipit-source-id: 6d97e641efc53fe6812872e9156b33d486439443
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Mar 29, 2023
Summary: Pull Request resolved: facebook#36704 Following up to facebook#36696, I accidentally failed a rebase and had files commited on the wrong folder. I'm updating them here to use `packages/react-native/template`. Changelog: [Internal] [Changed] - Move from from accidental template/ folder on root Reviewed By: cipolleschi Differential Revision: D44502966 fbshipit-source-id: e5e3c9cbb96175f7699f160c226d5fbd3315e757
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Mar 29, 2023
Summary: Pull Request resolved: facebook#36704 Following up to facebook#36696, I accidentally failed a rebase and had files commited on the wrong folder. I'm updating them here to use `packages/react-native/template`. Changelog: [Internal] [Changed] - Move from from accidental template/ folder on root Reviewed By: cipolleschi Differential Revision: D44502966 fbshipit-source-id: 5dcf1023a2e3e5cfdca5958f8e8655b6bd8e6a3f
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 29, 2023
Summary: Pull Request resolved: #36704 Following up to #36696, I accidentally failed a rebase and had files commited on the wrong folder. I'm updating them here to use `packages/react-native/template`. Changelog: [Internal] [Changed] - Move from from accidental template/ folder on root Reviewed By: cipolleschi Differential Revision: D44502966 fbshipit-source-id: d408f38884444c4ecc03852b1d145bf2e89df672
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
Summary: Pull Request resolved: facebook#36696 As the title says, we're converting the new app template to Kotlin. This will reduce the template size and make it more aligned to market standards. Changelog: [Android] [Changed] - Convert the app template to Kotlin Reviewed By: mdvacca Differential Revision: D44142081 fbshipit-source-id: 6111360b6580460eba0341e47c55704cc673e444
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
Summary: Pull Request resolved: facebook#36704 Following up to facebook#36696, I accidentally failed a rebase and had files commited on the wrong folder. I'm updating them here to use `packages/react-native/template`. Changelog: [Internal] [Changed] - Move from from accidental template/ folder on root Reviewed By: cipolleschi Differential Revision: D44502966 fbshipit-source-id: d408f38884444c4ecc03852b1d145bf2e89df672
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Pull Request resolved: facebook#36696 As the title says, we're converting the new app template to Kotlin. This will reduce the template size and make it more aligned to market standards. Changelog: [Android] [Changed] - Convert the app template to Kotlin Reviewed By: mdvacca Differential Revision: D44142081 fbshipit-source-id: 6111360b6580460eba0341e47c55704cc673e444
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Pull Request resolved: facebook#36704 Following up to facebook#36696, I accidentally failed a rebase and had files commited on the wrong folder. I'm updating them here to use `packages/react-native/template`. Changelog: [Internal] [Changed] - Move from from accidental template/ folder on root Reviewed By: cipolleschi Differential Revision: D44502966 fbshipit-source-id: d408f38884444c4ecc03852b1d145bf2e89df672
blakef
pushed a commit
to blakef/template
that referenced
this pull request
Feb 28, 2024
Summary: Pull Request resolved: facebook/react-native#36696 As the title says, we're converting the new app template to Kotlin. This will reduce the template size and make it more aligned to market standards. Changelog: [Android] [Changed] - Convert the app template to Kotlin Reviewed By: mdvacca Differential Revision: D44142081 fbshipit-source-id: 6111360b6580460eba0341e47c55704cc673e444 Original: facebook/react-native@c1c22eb
blakef
pushed a commit
to react-native-community/template
that referenced
this pull request
Feb 29, 2024
Summary: Pull Request resolved: facebook/react-native#36696 As the title says, we're converting the new app template to Kotlin. This will reduce the template size and make it more aligned to market standards. Changelog: [Android] [Changed] - Convert the app template to Kotlin Reviewed By: mdvacca Differential Revision: D44142081 fbshipit-source-id: 6111360b6580460eba0341e47c55704cc673e444 Original-Commit: facebook/react-native@c1c22eb
blakef
pushed a commit
to react-native-community/template
that referenced
this pull request
Feb 29, 2024
Summary: Pull Request resolved: facebook/react-native#36696 As the title says, we're converting the new app template to Kotlin. This will reduce the template size and make it more aligned to market standards. Changelog: [Android] [Changed] - Convert the app template to Kotlin Reviewed By: mdvacca Differential Revision: D44142081 fbshipit-source-id: 6111360b6580460eba0341e47c55704cc673e444 Original-Commit: facebook/react-native@c1c22eb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
As the title says, we're converting the new app template to Kotlin.
This will reduce the template size and make it more aligned to market standards.
Changelog:
[Android] [Changed] - Convert the app template to Kotlin
Reviewed By: mdvacca
Differential Revision: D44142081