-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port changes from main into Stable to make the CI green #36665
Merged
cipolleschi
merged 2 commits into
0.72-stable
from
cipolleschi/fix_disable_ios_integration_tests
Mar 28, 2023
Merged
Port changes from main into Stable to make the CI green #36665
cipolleschi
merged 2 commits into
0.72-stable
from
cipolleschi/fix_disable_ios_integration_tests
Mar 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
p: Facebook
Partner: Facebook
Partner
labels
Mar 27, 2023
cipolleschi
force-pushed
the
cipolleschi/fix_disable_ios_integration_tests
branch
from
March 27, 2023 18:25
c70961d
to
8a1f167
Compare
cipolleschi
changed the title
Port [RN] Fix paths in objc-test.sh, temporarily exclude /IntegrationTests from main
Port changes from main into Stable to make the CI green
Mar 28, 2023
cipolleschi
force-pushed
the
cipolleschi/fix_disable_ios_integration_tests
branch
from
March 28, 2023 13:01
7929d67
to
3cf42cc
Compare
cipolleschi
force-pushed
the
cipolleschi/fix_disable_ios_integration_tests
branch
from
March 28, 2023 13:08
3cf42cc
to
0db6355
Compare
Base commit: a83c192 |
cipolleschi
force-pushed
the
cipolleschi/fix_disable_ios_integration_tests
branch
3 times, most recently
from
March 28, 2023 15:45
63566d0
to
2104e77
Compare
Summary: Changelog: [General][Added] - Add `react-native/metro-config` package Pull Request resolved: #36502 ## Context ### React Native Metro config → React Native repo (#36502) We (the React Native team) are aiming to relocate the default Metro config for React Native out of `react-native-community/cli-plugin-metro` and **into the React Native repo + app template** as a new `react-native/metro-config` package. This is the first (and minimum viable) phase we can ship to separate the release process of Metro from RN CLI in order to reduce coupling and iterate faster for our users. **See full motivation, design, and test plan here: #36502 ## Changes - This PR adds the new `react-native/metro-config` package, reproduces all static values previously defined in RN CLI. The values which remain in RN CLI are dynamic values derived from CLI options passed by the user. {F906910591} Reviewed By: cortinico Differential Revision: D44099692 fbshipit-source-id: 672a67e19d866ac2c64fc84983b5d82c604918c6
cipolleschi
force-pushed
the
cipolleschi/fix_disable_ios_integration_tests
branch
from
March 28, 2023 16:10
2104e77
to
4d245cc
Compare
lunaleaps
approved these changes
Mar 28, 2023
This was referenced Aug 10, 2023
This was referenced Jan 4, 2024
This was referenced Jan 10, 2024
This was referenced Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Bug
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
p: Facebook
Partner: Facebook
Partner
Pick Request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change ports to 0.72 stable some other changes we are landing in main in order to solve the issues with Metro and the CLI
Changelog
[Internal][Fixed] - Make Metro run properly on RNTester, exluding the integration tests
Test Plan