Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update paths in React-rncore.podspec #36571

Closed
wants to merge 1 commit into from
Closed

fix: update paths in React-rncore.podspec #36571

wants to merge 1 commit into from

Commits on Mar 22, 2023

  1. fix: update paths in React-rncore.podspec (facebook#36571) 

    Summary:
Pull Request resolved: facebook#36571

Changelog: [Internal]

The problem is related to the way we use `js_srcs_dir` & `output_dir` options, one requires just relative path from current ruby script, other requires relative path from iOS root project (where the Podfile located)

output_dir was introduced in D43304641
resulted into the issue, described in https://discord.com/channels/514829729862516747/1087736932953509958

allow-large-files

Reviewed By: cipolleschi

Differential Revision: D44294112

fbshipit-source-id: 48b0b8a838502710c06a901c58eb9f5faffa48f1
    @hoxyq @facebook-github-bot
    hoxyq authored and facebook-github-bot committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    779f5e7 View commit details
    Browse the repository at this point in the history