fix: add missing lineBreakStrategyIOS types for Text, TextInput #36526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Base commit: e5b97f0 |
|
@javache has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
how do i do it if im using npm? |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
…book#36526) Summary: I added missing type `lineBreakStrategyIOS` for Text and TextInput. ([Text docs](https://reactnative.dev/docs/text)) ## Changelog [GENERAL] [FIXED] - add `lineBreakStrategyIOS` prop type for Text and TextInput <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> Pull Request resolved: facebook#36526 Test Plan: Ran `yarn test-typescript` and `yarn test-typescript-offline` with no errors. Reviewed By: jacdebug Differential Revision: D44213791 Pulled By: javache fbshipit-source-id: 8d0d44e2cdd1fa362c54935326e86dde88c5ba0b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I added missing type
lineBreakStrategyIOSfor Text and TextInput. (Text docs)Changelog
[GENERAL] [FIXED] - add
lineBreakStrategyIOSprop type for Text and TextInputTest Plan
Ran
yarn test-typescriptandyarn test-typescript-offlinewith no errors.