Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to commit with generic message #36421

Closed
wants to merge 1 commit into from

Conversation

hoxyq
Copy link
Contributor

@hoxyq hoxyq commented Mar 9, 2023

Summary:
Changelog: [Internal]

Adding an extra choice for commit question, user can now choose between three options:

  1. Commit with generic message, no further actions needed
  2. Commit with custom message, intercative VIM input will open
  3. Not committing anything

Differential Revision: D43943526

Summary:
Changelog: [Internal]

Adding an extra choice for commit question, user can now choose between three options:
1. Commit with generic message, no further actions needed
2. Commit with custom message, intercative VIM input will open
3. Not committing anything

Differential Revision: D43943526

fbshipit-source-id: 8c3462434ff7057923d80d17e6402610f4ef8794
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Mar 9, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43943526

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,515,397 +0
android hermes armeabi-v7a 7,831,285 +0
android hermes x86 8,995,721 +0
android hermes x86_64 8,851,197 +0
android jsc arm64-v8a 9,140,029 +0
android jsc armeabi-v7a 8,331,628 +0
android jsc x86 9,194,989 +0
android jsc x86_64 9,453,096 +0

Base commit: bcec590
Branch: main

@hoxyq hoxyq requested a review from kelset March 9, 2023 14:40
Copy link
Contributor

@kelset kelset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Mar 9, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 8d8b44a.

kelset pushed a commit that referenced this pull request Mar 28, 2023
Summary:
Pull Request resolved: #36421

Changelog: [Internal]

Adding an extra choice for commit question, user can now choose between three options:
1. Commit with generic message, no further actions needed
2. Commit with custom message, intercative VIM input will open
3. Not committing anything

Reviewed By: cortinico

Differential Revision: D43943526

fbshipit-source-id: 014215105d192961486b7d1c697f491697492812
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
Summary:
Pull Request resolved: facebook#36421

Changelog: [Internal]

Adding an extra choice for commit question, user can now choose between three options:
1. Commit with generic message, no further actions needed
2. Commit with custom message, intercative VIM input will open
3. Not committing anything

Reviewed By: cortinico

Differential Revision: D43943526

fbshipit-source-id: 014215105d192961486b7d1c697f491697492812
@cipolleschi cipolleschi mentioned this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants