[Codegen 92, 93] Move getCommandOptions and getOptions to parsers commons #36413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Base commit: b9c64f3 |
github-actions
bot
force-pushed
the
refactor/extract-getOptions
branch
from
7aa2ad4
to
e8a358f
Compare
|
@ryancat has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
tarunrajput
force-pushed
the
refactor/extract-getOptions
branch
from
e8a358f
to
10645c7
Compare
|
/rebase |
github-actions
bot
force-pushed
the
refactor/extract-getOptions
branch
from
10645c7
to
ca8b850
Compare
tarunrajput
force-pushed
the
refactor/extract-getOptions
branch
from
ca8b850
to
b27c296
Compare
tarunrajput
changed the title
tarunrajput
force-pushed
the
refactor/extract-getOptions
branch
2 times, most recently
from
1fc02ff
to
a7e6a26
Compare
|
/rebase |
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
github-actions
bot
force-pushed
the
refactor/extract-getOptions
branch
from
a7e6a26
to
f7b0081
Compare
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@cipolleschi merged this pull request in 221aacd. |
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
) Summary: > [Codegen 92] The getCommandOptions function in parsers/typescript/components/options.js and parsers/flow/components/options.js is the same. move it in parser-commons and use it in the original files. If the file two options.js files are empty, delete them. > [Codegen 93] The getOptions function in parsers/typescript/components/options.js and parsers/flow/components/options.js is the same. move it in parser-commons and use it in the original files. If the file two options.js files are empty, delete them. Part of Issue facebook#34872 ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [Internal][Changed] - Move getCommandOptions and getOptions to parsers commons from parsers components options Pull Request resolved: facebook#36413 Test Plan: `yarn jest react-native-codegen` Reviewed By: rshest Differential Revision: D43957023 Pulled By: cipolleschi fbshipit-source-id: 4f8bf6f8fe69b20d0fb976afee7da244ef634e12
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
) Summary: > [Codegen 92] The getCommandOptions function in parsers/typescript/components/options.js and parsers/flow/components/options.js is the same. move it in parser-commons and use it in the original files. If the file two options.js files are empty, delete them. > [Codegen 93] The getOptions function in parsers/typescript/components/options.js and parsers/flow/components/options.js is the same. move it in parser-commons and use it in the original files. If the file two options.js files are empty, delete them. Part of Issue facebook#34872 ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [Internal][Changed] - Move getCommandOptions and getOptions to parsers commons from parsers components options Pull Request resolved: facebook#36413 Test Plan: `yarn jest react-native-codegen` Reviewed By: rshest Differential Revision: D43957023 Pulled By: cipolleschi fbshipit-source-id: 4f8bf6f8fe69b20d0fb976afee7da244ef634e12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of Issue #34872
Changelog
[Internal][Changed] - Move getCommandOptions and getOptions to parsers commons from parsers components options
Test Plan
yarn jest react-native-codegen