Reduce breaking changes with DefaultReactActivityDelegate #36310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: As part of the preparation for 0.72, this reduces the amount of breaking changes we expose in the template for the user. Specifically it re-introduces the 4 param ctor for `DefaultReactActivityDelegate` and marking it with Deprecated, so the build log and the IDE will instruct the user to move away from it (if they forgot to follow the upgrade helper). Changelog: [Internal] [Changed] - Reduce breaking changes with DefaultReactActivityDelegate Reviewed By: cipolleschi Differential Revision: D43619184 fbshipit-source-id: b0998288fe768470d6759766790813f7ef695dd1
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D43619184 |
Base commit: 05438c3 |
|
This pull request has been merged in de4ed0d. |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
…6310) Summary: Pull Request resolved: facebook#36310 As part of the preparation for 0.72, this reduces the amount of breaking changes we expose in the template for the user. Specifically it re-introduces the 4 param ctor for `DefaultReactActivityDelegate` and marking it with Deprecated, so the build log and the IDE will instruct the user to move away from it (if they forgot to follow the upgrade helper). Changelog: [Internal] [Changed] - Reduce breaking changes with DefaultReactActivityDelegate Reviewed By: cipolleschi Differential Revision: D43619184 fbshipit-source-id: a98f7c67201a2860e7c2221e646f45f1ebec4678
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
As part of the preparation for 0.72, this reduces the amount of breaking changes we expose in the template for the user.
Specifically it re-introduces the 4 param ctor for
DefaultReactActivityDelegateand marking it with Deprecated,so the build log and the IDE will instruct the user to move away from it (if they forgot to follow the upgrade helper).
Changelog:
[Internal] [Changed] - Reduce breaking changes with DefaultReactActivityDelegate
Reviewed By: cipolleschi
Differential Revision: D43619184