Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dependencies): bump CLI to 11 alpha2 and metro to 0.75.1 #36271

Closed
wants to merge 2 commits into from

Conversation

kelset
Copy link
Contributor

@kelset kelset commented Feb 23, 2023

Summary

Ahead of cut of RN 0.72, I'm upgrading CLI and Metro according to https://github.com/react-native-community/cli/releases/tag/v11.0.0-alpha.2

While working on it, I noticed that run-ios has some changes that make the e2e test script not work super well, so I'll be checking in with the CLI team to figure out what's wrong. Let's not merge it until that's address it. (also, there's already a bump for Metro that we need react-native-community/cli@8d18bae so I'll probably change the version to latest CLI and Metro once more) (all addressed)

Changelog

[GENERAL] [CHANGED] - bump CLI to 11 alphav2 and metro to 0.75.1

Test Plan

Test CI, and locally I've used the e2e test script to ensure everything still works.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 23, 2023
@facebook-github-bot facebook-github-bot added Contributor A React Native contributor. p: Microsoft Partner: Microsoft Partner labels Feb 23, 2023
@github-actions
Copy link

github-actions bot commented Feb 23, 2023

Warnings
⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against ab7e101

@kelset kelset changed the title chore(dependencies): bump CLI to 11 alpha and metro to 0.75.0 DON'T MERGE YET - chore(dependencies): bump CLI to 11 alpha and metro to 0.75.0 Feb 23, 2023
@kelset kelset changed the title DON'T MERGE YET - chore(dependencies): bump CLI to 11 alpha and metro to 0.75.0 chore(dependencies): bump CLI to 11 alpha2 and metro to 0.75.1 Feb 24, 2023
enforce the simulator to go for the right device

podfile lock update to work (without this, pod install fails)

new bump

podlock

guess - podlock again
@analysis-bot
Copy link

analysis-bot commented Feb 24, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,472,621 +1,352
android hermes armeabi-v7a 7,794,716 +1,398
android hermes x86 8,948,038 +1,371
android hermes x86_64 8,805,323 +1,349
android jsc arm64-v8a 9,105,450 +48
android jsc armeabi-v7a 8,302,389 +88
android jsc x86 9,155,778 +63
android jsc x86_64 9,414,844 +43

Base commit: 446a412
Branch: main

Copy link
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small change, pls! 🙏

packages/rn-tester/Podfile.lock Outdated Show resolved Hide resolved
Copy link
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Feb 28, 2023
@facebook-github-bot
Copy link
Contributor

@cipolleschi merged this pull request in 5112bc5.

@kelset kelset deleted the kelset/bump-cli-for-main branch February 28, 2023 11:30
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
…ook#36271)

Summary:
Ahead of cut of RN 0.72, I'm upgrading CLI and Metro according to https://github.com/react-native-community/cli/releases/tag/v11.0.0-alpha.2

~While working on it, I noticed that run-ios has some changes that make the e2e test script not work super well, so I'll be checking in with the CLI team to figure out what's wrong. Let's not merge it until that's address it. (also, there's already a bump for Metro that we need react-native-community/cli@8d18bae so I'll probably change the version to latest CLI and Metro once more)~ (all addressed)

## Changelog

<!-- Help reviewers and the release process by writing your own changelog entry.

Pick one each for the category and type tags:

[ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message

For more details, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->

[GENERAL] [CHANGED] - bump CLI to 11 alphav2 and metro to 0.75.1

Pull Request resolved: facebook#36271

Test Plan: Test CI, and locally I've used the e2e test script to ensure everything still works.

Reviewed By: NickGerleman

Differential Revision: D43625952

Pulled By: cipolleschi

fbshipit-source-id: dad940b65c56a586ae82acc2e7c16a918b872ee5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. Merged This PR has been merged. p: Microsoft Partner: Microsoft Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants