Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Codegen 82] Move isModuleInterface function (Flow, TypeScript) to the Flow and TypeScript parsers. #36268

Closed
wants to merge 2 commits into from
Closed

[Codegen 82] Move isModuleInterface function (Flow, TypeScript) to the Flow and TypeScript parsers. #36268

wants to merge 2 commits into from

Conversation

kyawthura-gg
Copy link
Contributor

Summary

Task from #34872

[Codegen 82] Move isModuleInterface function (Flow, TypeScript) to the Flow and TypeScript parsers.

Changelog

[INTERNAL] [CHANGED] - Moved isModuleInterface function to to the Flow and TypeScript parsers.

Test Plan

yarn test react-native-codegen

@facebook-github-bot
Copy link
Contributor

Hi @kyawthura-gg!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,458,634 +0
android hermes armeabi-v7a 7,781,895 +0
android hermes x86 8,934,535 +0
android hermes x86_64 8,791,624 +0
android jsc arm64-v8a 9,092,772 +0
android jsc armeabi-v7a 8,290,869 +0
android jsc x86 9,143,590 +0
android jsc x86_64 9,402,455 +0

Base commit: 26b2bb5
Branch: main

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 23, 2023
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot
Copy link
Contributor

@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

cipolleschi
cipolleschi requested changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the parsers/__tests__ folder there is a file that is called parsers-tests.js.\

It would be nice to have some unit tests for the Flow parser and for the TypeScript parsers to unit tests the isModuleInterface function.

Would you mind adding them?

packages/react-native-codegen/src/parsers/flow/modules/index.js Show resolved Hide resolved
@facebook-github-bot
Copy link
Contributor

@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Feb 23, 2023
@facebook-github-bot
Copy link
Contributor

@rshest merged this pull request in 85245af.

@kyawthura-gg kyawthura-gg deleted the fix/move-ismoduleinterface-to-parsers branch February 24, 2023 01:12
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
@kyawthura-gg @OlimpiaZurek
Move isModuleInterface function (Flow, TypeScript) to the Flow and Ty…
2f207db 
…peScript parsers. (facebook#36268)

Summary:
Task from facebook#34872

> [Codegen 82] Move isModuleInterface function (Flow, TypeScript) to the Flow and TypeScript parsers.

## Changelog

[INTERNAL] [CHANGED] - Moved isModuleInterface function to to the Flow and TypeScript parsers.

Pull Request resolved: facebook#36268

Test Plan: ` yarn test react-native-codegen`

Reviewed By: christophpurrer

Differential Revision: D43535948

Pulled By: rshest

fbshipit-source-id: 7a2db05008783499168b0ce3fa58fedbac2b4e79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rshest rshest rshest approved these changes

@cipolleschi cipolleschi Awaiting requested review from cipolleschi

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kyawthura-gg @facebook-github-bot @analysis-bot @rshest @cipolleschi