Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): fix pod install --project-directory=... #36096

Merged
merged 1 commit into from
Feb 13, 2023
Merged

fix(ios): fix pod install --project-directory=... #36096

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion scripts/react_native_pods.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,8 @@ def react_native_post_install(installer, react_native_path = "../node_modules/re
flipper_post_install(installer)
end

package = JSON.parse(File.read(File.join(react_native_path, "package.json")))
package_path = File.join(Pod::Config.instance.installation_root, react_native_path, "package.json")
package = JSON.parse(File.read(package_path))
Comment on lines +212 to +213
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As done like this, it breaks RNTester, unfortunately. Should we find a better way to handle this? 🤔

Copy link
Collaborator Author

@tido64 tido64 Feb 10, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does it break RNTester? I printed out the output and it looks correct to me?

 Generating Pods project
+"/~/react-native/packages/rn-tester/../../package.json"
 Setting REACT_NATIVE build settings
 Setting CLANG_CXX_LANGUAGE_STANDARD to c++17 on /~/react-native/packages/rn-tester/RNTesterPods.xcodeproj
 Pod install took 12 [s] to run
 Integrating client project
 Pod installation complete! There are 67 dependencies from the Podfile and 55 total pods installed.

The installation also succeeded…

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad the RNTester and CircleCI issue is due to hermes-engine versions... 🤦

version = package['version']

if ReactNativePodsUtils.has_pod(installer, 'hermes-engine') && is_building_hermes_from_source(version, react_native_path)
Expand Down