Add automatic RN version checking workflow #36075
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Base commit: c5bc3f1 |
|
@SlyCaptainFlint has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
2 similar comments
|
@SlyCaptainFlint has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@SlyCaptainFlint has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
kelset
reviewed
Feb 9, 2023
kelset
approved these changes
Feb 14, 2023
cortinico
approved these changes
Feb 14, 2023
|
@SlyCaptainFlint has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cortinico
requested changes
Feb 16, 2023
|
/rebase |
SlyCaptainFlint
force-pushed
the
main
branch
from
309d1fc to
4cc2293
Compare
cortinico
approved these changes
Feb 22, 2023
|
@SlyCaptainFlint has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
added 10 commits
February 22, 2023 15:23
… of RN listed in the issue is supported. also, refactoring the existing label actions workflow to also support the addition of the RN version verifier. editing the two issue templates slightly to make the version match regex more reliable
… consistent with the regular bug report
SlyCaptainFlint
force-pushed
the
main
branch
from
4cc2293 to
4f4eac0
Compare
|
@SlyCaptainFlint has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@SlyCaptainFlint merged this pull request in 26b2bb5. |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Adding automatic RN version checking github workflow, which will verify the version of RN listed on all new issues filed in the repository. Additionally, this change refactors the existing labeler workflow to make it re-usable by the version check workflow. The change also creates a logical place to add future automatic detection checks, like auto-verification of repro, template, etc. This is technically not new functionality, as the react-native-bot does this _sometimes_, but this should be a lot more reliable. The logic for valid release checking follows what is listed in the documentation - valid versions are current and N-2 minors, with the highest available patches. ## Changelog [INTERNAL] [FIXED] - Made the automated RN version checking workflow more reliable Pull Request resolved: facebook#36075 Test Plan: I have verified a variety of different versions on issues here: https://github.com/SlyCaptainFlint/react-native/issues I have also re-verified all the tags that were previously handled by the labeler workflow, since I have refactored it. Please take a look at both the open and closed issues in the linked repo for examples. Reviewed By: cortinico Differential Revision: D43089150 Pulled By: SlyCaptainFlint fbshipit-source-id: 7da67f5cb2a4875f22e1f9e46d7ca07d43f3e135
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding automatic RN version checking github workflow, which will verify the version of RN listed on all new issues filed in the repository.
Additionally, this change refactors the existing labeler workflow to make it re-usable by the version check workflow. The change also creates a logical place to add future automatic detection checks, like auto-verification of repro, template, etc.
This is technically not new functionality, as the react-native-bot does this sometimes, but this should be a lot more reliable.
The logic for valid release checking follows what is listed in the documentation - valid versions are current and N-2 minors, with the highest available patches.
Changelog
[INTERNAL] [FIXED] - Made the automated RN version checking workflow more reliable
Test Plan
I have verified a variety of different versions on issues here: https://github.com/SlyCaptainFlint/react-native/issues
I have also re-verified all the tags that were previously handled by the labeler workflow, since I have refactored it. Please take a look at both the open and closed issues in the linked repo for examples.