Turbo Module supports intersection type for TypeScript #36037
Closed
+255
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Closed
Base commit: 7fedd75 |
cipolleschi
reviewed
Feb 2, 2023
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
ZihanChen-MSFT
force-pushed
the
ts-rncodegen19
branch
from
d1cbb79 to
a2b9ae8
Compare
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@cipolleschi merged this pull request in bbed15d. |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: As [requested from community](reactwg/react-native-new-architecture#91 (comment)), intersection type is supported for component but no in turbo module. This PR fixed it. ## Changelog [GENERAL] [CHANGED] - Turbo Module supports intersection type for TypeScript Pull Request resolved: facebook#36037 Test Plan: `yarn jest react-native-codegen` passed Reviewed By: christophpurrer Differential Revision: D42960338 Pulled By: cipolleschi fbshipit-source-id: d317d3155cb96643bf549d0ac3d77f503685edbc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As requested from community, intersection type is supported for component but no in turbo module. This PR fixed it.
Changelog
[GENERAL] [CHANGED] - Turbo Module supports intersection type for TypeScript
Test Plan
yarn jest react-native-codegenpassed