Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add changelog for 0.68.6 and 0.69.8 #36010

Closed
wants to merge 3 commits into from
Closed

chore: Add changelog for 0.68.6 and 0.69.8 #36010

wants to merge 3 commits into from

Conversation

dmytrorykun
Copy link
Contributor

@dmytrorykun dmytrorykun commented Jan 30, 2023 •
edited by kelset
Loading

Summary

Create changelog for 0.69.8

Changelog

[Internal] [Changed] - add changelog entry for 0.69.8

Test Plan

N/A

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Jan 30, 2023
kelset
kelset suggested changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@kelset kelset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for setting this up, let's clean it then it can go in

CHANGELOG.md Outdated Show resolved Hide resolved
@kelset kelset added the 📝 Changelog This identifies PRs that touch the changelog label Jan 31, 2023
@facebook-github-bot
Copy link
Contributor

@dmytrorykun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@analysis-bot
Copy link

analysis-bot commented Jan 31, 2023 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,463,485 -63
android hermes armeabi-v7a 7,783,882 -81
android hermes x86 8,936,549 -73
android hermes x86_64 8,794,587 -74
android jsc arm64-v8a 9,648,925 -34
android jsc armeabi-v7a 8,383,202 -24
android jsc x86 9,710,897 -26
android jsc x86_64 10,187,754 -23

Base commit: 86852f8
Branch: main

kelset
kelset reviewed Jan 31, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
kelset
kelset suggested changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@kelset kelset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also do 0.68 in this same PR? that'd be faster to handle then 2 separate PRs

@dmytrorykun dmytrorykun changed the title chore: Update changelog for 0.69.8 chore: Add changelog for 0.68.6 and 0.69.8 Jan 31, 2023
@facebook-github-bot
Copy link
Contributor

@dmytrorykun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jan 31, 2023
@facebook-github-bot
Copy link
Contributor

@dmytrorykun merged this pull request in b086e5d.

@kelset kelset deleted the dmytrorykun/add-changelog-69-8 branch January 31, 2023 16:18
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
@OlimpiaZurek
chore: Add changelog for 0.68.6 and 0.69.8 (facebook#36010)
225db6e 
Summary:
Create changelog for 0.69.8

## Changelog
[Internal] [Changed] - add changelog entry for 0.69.8

Pull Request resolved: facebook#36010

Test Plan: N/A

Reviewed By: rshest

Differential Revision: D42882254

Pulled By: dmytrorykun

fbshipit-source-id: 2cf12ab1898d292bd525d9c357203c69b58b3247
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelset kelset kelset approved these changes

Assignees
No one assigned
Labels
📝 Changelog This identifies PRs that touch the changelog CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dmytrorykun @facebook-github-bot @analysis-bot @kelset