fix(publishing-bumped-packages): look for status code instaead of stderr #36004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D42836212 |
kelset
reviewed
Jan 30, 2023
| cwd: packageAbsolutePath, | ||
| shell: true, | ||
| stdio: 'pipe', | ||
| encoding: 'utf-8', | ||
| }); | ||
| if (stderr) { | ||
| if (status !== 0) { |
There was a problem hiding this comment.
can we maybe get back both stderr and status and if status is != 0 print both status and stderr? To get better understanding of what's failing 👍
There was a problem hiding this comment.
can we maybe get back both stderr and status and if status is != 0 print both status and stderr? To get better understanding of what's failing 👍
Yeah, somehow missed that, will get it back
…err (facebook#36004) Summary: Pull Request resolved: facebook#36004 Changelog: [Internal] This fixes CircleCI job, which is responsible for publishing bumped packages. We should not check for `stderr`, apparently `npm` uses it to store debug information: - npm/npm#118 (comment) So we've tried to use this on 0.71-stable before and it succesfully published one package, but have exited right after it because `stderr` was not empty Reviewed By: cipolleschi Differential Revision: D42836212 fbshipit-source-id: a09cb7adc750cbb9e735bdefbe92050f9f5767c6
|
This pull request was exported from Phabricator. Differential Revision: D42836212 |
hoxyq
force-pushed
the
export-D42836212
branch
from
e5597b5
to
8399050
Compare
Base commit: e91e468 |
kelset
approved these changes
Jan 30, 2023
|
This pull request has been merged in 9856c33. |
kelset
pushed a commit
that referenced
this pull request
Jan 30, 2023
…err (#36004) Summary: Pull Request resolved: #36004 Changelog: [Internal] This fixes CircleCI job, which is responsible for publishing bumped packages. We should not check for `stderr`, apparently `npm` uses it to store debug information: - npm/npm#118 (comment) So we've tried to use this on 0.71-stable before and it succesfully published one package, but have exited right after it because `stderr` was not empty Reviewed By: cortinico, cipolleschi Differential Revision: D42836212 fbshipit-source-id: 6f2a9a512121683268fe6aae6a187fccb8d9dfbc
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
…err (facebook#36004) Summary: Pull Request resolved: facebook#36004 Changelog: [Internal] This fixes CircleCI job, which is responsible for publishing bumped packages. We should not check for `stderr`, apparently `npm` uses it to store debug information: - npm/npm#118 (comment) So we've tried to use this on 0.71-stable before and it succesfully published one package, but have exited right after it because `stderr` was not empty Reviewed By: cortinico, cipolleschi Differential Revision: D42836212 fbshipit-source-id: 6f2a9a512121683268fe6aae6a187fccb8d9dfbc
Merged
This was referenced Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
This fixes CircleCI job, which is responsible for publishing bumped packages. We should not check for
stderr, apparentlynpmuses it to store debug information:So we've tried to use this on 0.71-stable before and it succesfully published one package, but have exited right after it because
stderrwas not emptyDifferential Revision: D42836212