Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simple support to the Partial<T> annotation (#35960) #35961

Closed
wants to merge 1 commit into from
Closed

simple support to the Partial<T> annotation (#35960) #35961

wants to merge 1 commit into from

Conversation

vzaidman
Copy link
Contributor

@vzaidman vzaidman commented Jan 25, 2023 •
edited
Loading

Summary:
Pull Request resolved: #35960

This fixes #35864

This feature allows using $Partial<Obj> in flow and Partial<Obj> in TypeScript based on the spec mentioned here: https://flow.org/en/docs/types/utilities/#toc-partial.

We currently only allow passing an Obj to Partial so

export type SomeObj = {
  a: string,
  b?: boolean,
};

export type PartialSomeObj = Partial<SomeObj>;

should work.
and also-

export type PartialSomeObj = Partial<{
  a: string,
  b?: boolean,
}>;

But not

export type PartialSomeObj = Partial<Partial<{
  a: string,
  b?: boolean,
}>>;

This can be improved in the future by a recursive unwrapping of the value inside the Partial annotation.

Changelog:
[General] [Added] - Allow the use of "Partial" in Turbo Module specs.

Reviewed By: christophpurrer, cipolleschi

Differential Revision: D42640880

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Jan 25, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D42640880

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D42640880

vzaidman added a commit to vzaidman/react-native that referenced this pull request Jan 25, 2023
@vzaidman @facebook-github-bot
simple support to the Partial<T> annotation (facebook#35961)
367d143 
Summary:
Pull Request resolved: facebook#35961

Pull Request resolved: facebook#35960

This fixes facebook#35864

This feature allows using `$Partial<Obj>` in flow and `Partial<Obj>` in TypeScript based on the spec mentioned here: https://flow.org/en/docs/types/utilities/#toc-partial.

We currently only allow passing an Obj to Partial so
```
export type SomeObj = {
  a: string,
  b?: boolean,
};

export type PartialSomeObj = Partial<SomeObj>;
```
should work.
and also-
```
export type PartialSomeObj = Partial<{
  a: string,
  b?: boolean,
}>;
```
But not
```
export type PartialSomeObj = Partial<Partial<{
  a: string,
  b?: boolean,
}>>;
```
This can be improved in the future by a recursive unwrapping of the value inside the `Partial` annotation.

Changelog:
[General] [Added] -  Allow the use of "Partial<T>" in Turbo Module specs.

Reviewed By: christophpurrer, cipolleschi

Differential Revision: D42640880

fbshipit-source-id: 7f55e6cb2eec41f5e9d085b21b9ffd658b665140
@react-native-bot react-native-bot added the Type: Enhancement A new feature or enhancement of an existing feature. label Jan 25, 2023
@vzaidman @facebook-github-bot
simple support to the Partial<T> annotation (facebook#35961)
566609e 
Summary:
Pull Request resolved: facebook#35961

Pull Request resolved: facebook#35960

This fixes facebook#35864

This feature allows using `$Partial<Obj>` in flow and `Partial<Obj>` in TypeScript based on the spec mentioned here: https://flow.org/en/docs/types/utilities/#toc-partial.

We currently only allow passing an Obj to Partial so
```
export type SomeObj = {
  a: string,
  b?: boolean,
};

export type PartialSomeObj = Partial<SomeObj>;
```
should work.
and also-
```
export type PartialSomeObj = Partial<{
  a: string,
  b?: boolean,
}>;
```
But not
```
export type PartialSomeObj = Partial<Partial<{
  a: string,
  b?: boolean,
}>>;
```
This can be improved in the future by a recursive unwrapping of the value inside the `Partial` annotation.

Changelog:
[General] [Added] -  Allow the use of "Partial<T>" in Turbo Module specs.

Reviewed By: christophpurrer, cipolleschi

Differential Revision: D42640880

fbshipit-source-id: eba1ef64dd3a0c95d267a04f9e56cb8641ccbbf2
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D42640880

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,462,911 +0
android hermes armeabi-v7a 7,783,489 +0
android hermes x86 8,936,172 +0
android hermes x86_64 8,794,233 +0
android jsc arm64-v8a 9,648,873 +0
android jsc armeabi-v7a 8,383,370 +0
android jsc x86 9,711,124 +0
android jsc x86_64 10,188,137 +0

Base commit: 2bfb53c
Branch: main

vzaidman added a commit to vzaidman/react-native that referenced this pull request Jan 26, 2023
@vzaidman @facebook-github-bot
simple support to the Partial<T> annotation (facebook#35961)
813184a 
Summary:
Pull Request resolved: facebook#35961

Pull Request resolved: facebook#35960

This fixes facebook#35864

This feature allows using `$Partial<Obj>` in flow and `Partial<Obj>` in TypeScript based on the spec mentioned here: https://flow.org/en/docs/types/utilities/#toc-partial.

We currently only allow passing an Obj to Partial so
```
export type SomeObj = {
  a: string,
  b?: boolean,
};

export type PartialSomeObj = Partial<SomeObj>;
```
should work.
and also-
```
export type PartialSomeObj = Partial<{
  a: string,
  b?: boolean,
}>;
```
But not
```
export type PartialSomeObj = Partial<Partial<{
  a: string,
  b?: boolean,
}>>;
```
This can be improved in the future by a recursive unwrapping of the value inside the `Partial` annotation.

Changelog:
[General] [Added] -  Allow the use of "Partial<T>" in Turbo Module specs.

Reviewed By: christophpurrer, cipolleschi

Differential Revision: D42640880

fbshipit-source-id: e0b863c6863c312cc7b77438b326bfa5ed845d33
vzaidman added a commit to vzaidman/react-native that referenced this pull request Jan 26, 2023
@vzaidman @facebook-github-bot
simple support to the Partial<T> annotation (facebook#35961)
3f84c58 
Summary:
Pull Request resolved: facebook#35961

Pull Request resolved: facebook#35960

This fixes facebook#35864

This feature allows using `$Partial<Obj>` in flow and `Partial<Obj>` in TypeScript based on the spec mentioned here: https://flow.org/en/docs/types/utilities/#toc-partial.

We currently only allow passing an Obj to Partial so
```
export type SomeObj = {
  a: string,
  b?: boolean,
};

export type PartialSomeObj = Partial<SomeObj>;
```
should work.
and also-
```
export type PartialSomeObj = Partial<{
  a: string,
  b?: boolean,
}>;
```
But not
```
export type PartialSomeObj = Partial<Partial<{
  a: string,
  b?: boolean,
}>>;
```
This can be improved in the future by a recursive unwrapping of the value inside the `Partial` annotation.

Changelog:
[General] [Added] -  Allow the use of "Partial<T>" in Turbo Module specs.

Reviewed By: christophpurrer, cipolleschi

Differential Revision: D42640880

fbshipit-source-id: 0caf8a600313d27efed83696359d0b3eca025303
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jan 26, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 97e707d.

@vzaidman vzaidman deleted the export-D42640880 branch January 26, 2023 23:49
Tyson39
Tyson39 reviewed Apr 1, 2023
View reviewed changes
Copy link

@Tyson39 Tyson39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@facebook-github-bot

OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
@vzaidman @OlimpiaZurek
simple support to the Partial<T> annotation (facebook#35961)
0176d2e 
Summary:
Pull Request resolved: facebook#35961

Pull Request resolved: facebook#35960

This fixes facebook#35864

This feature allows using `$Partial<Obj>` in flow and `Partial<Obj>` in TypeScript based on the spec mentioned here: https://flow.org/en/docs/types/utilities/#toc-partial.

We currently only allow passing an Obj to Partial so
```
export type SomeObj = {
  a: string,
  b?: boolean,
};

export type PartialSomeObj = Partial<SomeObj>;
```
should work.
and also-
```
export type PartialSomeObj = Partial<{
  a: string,
  b?: boolean,
}>;
```
But not
```
export type PartialSomeObj = Partial<Partial<{
  a: string,
  b?: boolean,
}>>;
```
This can be improved in the future by a recursive unwrapping of the value inside the `Partial` annotation.

Changelog:
[General] [Added] -  Allow the use of "Partial<T>" in Turbo Module specs.

Reviewed By: christophpurrer, cipolleschi

Differential Revision: D42640880

fbshipit-source-id: 03a3fccc38ccfc7a5440fe11893beb68e77753f3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tyson39 Tyson39 Tyson39 left review comments

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner Type: Enhancement A new feature or enhancement of an existing feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Partial<Type> or $Partial<Type> are not supported in react-native-codegen
5 participants
@vzaidman @facebook-github-bot @analysis-bot @Tyson39 @react-native-bot