Don't use the internal native_modules.rb script yet
#35531
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
cortinico
approved these changes
Dec 2, 2022
|
I'll leave to @kelset to merge this |
tido64
force-pushed
the
tido/fix-template-0.71
branch
from
9cb8978
to
76dd07b
Compare
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Base commit: 759056b |
Base commit: 759056b |
|
This pull request was successfully merged by @tido64 in 4df793f. When will my fix make it into a release? | Upcoming Releases |
kelset
pushed a commit
that referenced
this pull request
Dec 13, 2022
Summary: Revert the template `Podfile` to using `react-native-community/cli-platform-ios/native_modules`. The new internal script currently has a hard-coded path to `react-native-community/cli-platform-ios` which may not work in monorepos. The path in the `Podfile` is also hard-coded, but this is a file that the user has access to and can fix themselves if necessary. ## Changelog [iOS] [Fixed] - Don't use the internal `native_modules.rb` script yet, as it hides a hard-coded path Pull Request resolved: #35531 Test Plan: n/a Reviewed By: rshest Differential Revision: D41682119 Pulled By: cortinico fbshipit-source-id: 1822fcd20a794dc9df6e8d6f36615e90b42c1a94
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Revert the template `Podfile` to using `react-native-community/cli-platform-ios/native_modules`. The new internal script currently has a hard-coded path to `react-native-community/cli-platform-ios` which may not work in monorepos. The path in the `Podfile` is also hard-coded, but this is a file that the user has access to and can fix themselves if necessary. ## Changelog [iOS] [Fixed] - Don't use the internal `native_modules.rb` script yet, as it hides a hard-coded path Pull Request resolved: facebook#35531 Test Plan: n/a Reviewed By: rshest Differential Revision: D41682119 Pulled By: cortinico fbshipit-source-id: 1822fcd20a794dc9df6e8d6f36615e90b42c1a94
Merged
This was referenced Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Revert the template
Podfileto using@react-native-community/cli-platform-ios/native_modules. The new internal script currently has a hard-coded path to@react-native-community/cli-platform-ioswhich may not work in monorepos. The path in thePodfileis also hard-coded, but this is a file that the user has access to and can fix themselves if necessary.Changelog
[iOS] [Fixed] - Don't use the internal
native_modules.rbscript yet, as it hides a hard-coded pathTest Plan
n/a