[RN][iOS] Do not add LongLivedObject wrapper in OSS #35491
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Base commit: 10a8f18 |
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Closing this as I'm working on a Stack internally to fix |
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Nov 28, 2022
Summary: This change excludes the `LongLivedObject.h` file from the pod in the ReactCommon library. The file creates a problem when the `use_frameworks!` option is used in an app because there can't be two files with the same name, despite being in different paths, within the same framework. Specifically, this `LongLivedObject` is just a redirect to the other one, so it should be safe to exclude this. ## Changelog [iOS][Fixed] - Exclude redirector to `LongLivedObject.h` from ReactCommon podspec Pull Request resolved: facebook#35491 Test Plan: 1. Manually tested in an app from RC2 Differential Revision: D41548985 Pulled By: cipolleschi fbshipit-source-id: c58b07aa2eb2d0f526478185a9b08f95299facd5
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Nov 28, 2022
Summary: This change excludes the `LongLivedObject.h` file from the pod in the ReactCommon library. The file creates a problem when the `use_frameworks!` option is used in an app because there can't be two files with the same name, despite being in different paths, within the same framework. Specifically, this `LongLivedObject` is just a redirect to the other one, so it should be safe to exclude this. ## Changelog [iOS][Fixed] - Exclude redirector to `LongLivedObject.h` from ReactCommon podspec Pull Request resolved: facebook#35491 Test Plan: 1. Manually tested in an app from RC2 Differential Revision: https://internalfb.com/D41548985 Pulled By: cipolleschi fbshipit-source-id: 7f85279e1e38128d4683edf063d07dbfdaf66a0d
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Nov 28, 2022
Summary: This change excludes the `LongLivedObject.h` file from the pod in the ReactCommon library. The file creates a problem when the `use_frameworks!` option is used in an app because there can't be two files with the same name, despite being in different paths, within the same framework. Specifically, this `LongLivedObject` is just a redirect to the other one, so it should be safe to exclude this. ## Changelog [iOS][Fixed] - Exclude redirector to `LongLivedObject.h` from ReactCommon podspec Pull Request resolved: facebook#35491 Test Plan: 1. Manually tested in an app from RC2 Differential Revision: https://internalfb.com/D41548985 Pulled By: cipolleschi fbshipit-source-id: 4ef203688c43bdd586ce02c5081a36b604acc2f6
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Nov 28, 2022
Summary: This change excludes the `LongLivedObject.h` file from the pod in the ReactCommon library. The file creates a problem when the `use_frameworks!` option is used in an app because there can't be two files with the same name, despite being in different paths, within the same framework. Specifically, this `LongLivedObject` is just a redirect to the other one, so it should be safe to exclude this. ## Changelog [iOS][Fixed] - Exclude redirector to `LongLivedObject.h` from ReactCommon podspec Pull Request resolved: facebook#35491 Test Plan: 1. Manually tested in an app from RC2 Differential Revision: https://internalfb.com/D41548985 Pulled By: cipolleschi fbshipit-source-id: 38878f923bfaec1b7e83413d8ad62a65f2545922
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Nov 28, 2022
Summary: This change excludes the `LongLivedObject.h` file from the pod in the ReactCommon library. The file creates a problem when the `use_frameworks!` option is used in an app because there can't be two files with the same name, despite being in different paths, within the same framework. Specifically, this `LongLivedObject` is just a redirect to the other one, so it should be safe to exclude this. ## Changelog [iOS][Fixed] - Exclude redirector to `LongLivedObject.h` from ReactCommon podspec Pull Request resolved: facebook#35491 Test Plan: 1. Manually tested in an app from RC2 Differential Revision: https://internalfb.com/D41548985 Pulled By: cipolleschi fbshipit-source-id: c7736093a869e19956bacd7273edc19799417dc0
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Nov 28, 2022
Summary: This change excludes the `LongLivedObject.h` file from the pod in the ReactCommon library. The file creates a problem when the `use_frameworks!` option is used in an app because there can't be two files with the same name, despite being in different paths, within the same framework. Specifically, this `LongLivedObject` is just a redirect to the other one, so it should be safe to exclude this. ## Changelog [iOS][Fixed] - Exclude redirector to `LongLivedObject.h` from ReactCommon podspec Pull Request resolved: facebook#35491 Test Plan: 1. Manually tested in an app from RC2 Differential Revision: https://internalfb.com/D41548985 Pulled By: cipolleschi fbshipit-source-id: 0807eee9cd22f558465d5d708b14ed02a003bb7f
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Nov 28, 2022
Summary: This change excludes the `LongLivedObject.h` file from the pod in the ReactCommon library. The file creates a problem when the `use_frameworks!` option is used in an app because there can't be two files with the same name, despite being in different paths, within the same framework. Specifically, this `LongLivedObject` is just a redirect to the other one, so it should be safe to exclude this. ## Changelog [iOS][Fixed] - Exclude redirector to `LongLivedObject.h` from ReactCommon podspec Pull Request resolved: facebook#35491 Test Plan: 1. Manually tested in an app from RC2 Differential Revision: https://internalfb.com/D41548985 Pulled By: cipolleschi fbshipit-source-id: b78f420283be54f894f48aba8cc040f47f1791ad
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Nov 28, 2022
Summary: This change excludes the `LongLivedObject.h` file from the pod in the ReactCommon library. The file creates a problem when the `use_frameworks!` option is used in an app because there can't be two files with the same name, despite being in different paths, within the same framework. Specifically, this `LongLivedObject` is just a redirect to the other one, so it should be safe to exclude this. ## Changelog [iOS][Fixed] - Exclude redirector to `LongLivedObject.h` from ReactCommon podspec Pull Request resolved: facebook#35491 Test Plan: 1. Manually tested in an app from RC2 Differential Revision: https://internalfb.com/D41548985 Pulled By: cipolleschi fbshipit-source-id: c88ede4e1b978a8af0506e6c42e6f2bd5c50a506
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Nov 28, 2022
Summary: This change excludes the `LongLivedObject.h` file from the pod in the ReactCommon library. The file creates a problem when the `use_frameworks!` option is used in an app because there can't be two files with the same name, despite being in different paths, within the same framework. Specifically, this `LongLivedObject` is just a redirect to the other one, so it should be safe to exclude this. ## Changelog [iOS][Fixed] - Exclude redirector to `LongLivedObject.h` from ReactCommon podspec Pull Request resolved: facebook#35491 Test Plan: 1. Manually tested in an app from RC2 Differential Revision: https://internalfb.com/D41548985 Pulled By: cipolleschi fbshipit-source-id: 5ff5b0eaf43fea4abd67f091482bd80fc11ec05c
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 29, 2022
Summary: This change excludes the `LongLivedObject.h` file from the pod in the ReactCommon library. The file creates a problem when the `use_frameworks!` option is used in an app because there can't be two files with the same name, despite being in different paths, within the same framework. Specifically, this `LongLivedObject` is just a redirect to the other one, so it should be safe to exclude this. ## Changelog [iOS][Fixed] - Exclude redirector to `LongLivedObject.h` from ReactCommon podspec Pull Request resolved: #35491 Test Plan: 1. Manually tested in an app from RC2 Reviewed By: cortinico Differential Revision: D41548985 Pulled By: cipolleschi fbshipit-source-id: acc57fccdedb344a3aa105f2968645a049392e07
|
This pull request was successfully merged by @cipolleschi in dd0bf83. When will my fix make it into a release? | Upcoming Releases |
kelset
pushed a commit
that referenced
this pull request
Nov 30, 2022
Summary: This change excludes the `LongLivedObject.h` file from the pod in the ReactCommon library. The file creates a problem when the `use_frameworks!` option is used in an app because there can't be two files with the same name, despite being in different paths, within the same framework. Specifically, this `LongLivedObject` is just a redirect to the other one, so it should be safe to exclude this. ## Changelog [iOS][Fixed] - Exclude redirector to `LongLivedObject.h` from ReactCommon podspec Pull Request resolved: #35491 Test Plan: 1. Manually tested in an app from RC2 Reviewed By: cortinico Differential Revision: D41548985 Pulled By: cipolleschi fbshipit-source-id: acc57fccdedb344a3aa105f2968645a049392e07
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: This change excludes the `LongLivedObject.h` file from the pod in the ReactCommon library. The file creates a problem when the `use_frameworks!` option is used in an app because there can't be two files with the same name, despite being in different paths, within the same framework. Specifically, this `LongLivedObject` is just a redirect to the other one, so it should be safe to exclude this. ## Changelog [iOS][Fixed] - Exclude redirector to `LongLivedObject.h` from ReactCommon podspec Pull Request resolved: facebook#35491 Test Plan: 1. Manually tested in an app from RC2 Reviewed By: cortinico Differential Revision: D41548985 Pulled By: cipolleschi fbshipit-source-id: acc57fccdedb344a3aa105f2968645a049392e07
Merged
This was referenced Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change excludes the
LongLivedObject.hfile from the pod in the ReactCommon library.The file creates a problem when the
use_frameworks!option is used in an app because there can't be two files with the same name, despite being in different paths,within the same framework. Specifically, this
LongLivedObjectis just a redirect to the other one, so it should be safe to exclude this.Changelog
[iOS][Fixed] - Exclude redirector to
LongLivedObject.hfrom ReactCommon podspecTest Plan