-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate hermes-executor-debug and -release inside a single target #35454
Conversation
This pull request was exported from Phabricator. Differential Revision: D41519119 |
Base commit: 9517320 |
Base commit: 9517320 |
PR build artifact for 7998629 is ready. |
PR build artifact for 7998629 is ready. |
…facebook#35454) Summary: Pull Request resolved: facebook#35454 Historically, we used to have hermes-executor debug and release as separate dynamic libraries. This makes it impossible to prefab this library, so I have to reconcile it into a single library. This will also help keep the setup consistent with the internal (BUCK) where we have a single target. Changelog: [Internal] [Changed] - Consolidate hermes-executor-debug and -release inside a single target Differential Revision: D41519119 fbshipit-source-id: 744c8a15607d8b6178d27deffac2b35746a215d5
This pull request was exported from Phabricator. Differential Revision: D41519119 |
7998629
to
1357d6f
Compare
PR build artifact for 1357d6f is ready. |
PR build artifact for 1357d6f is ready. |
This pull request was successfully merged by @cortinico in fe2716b. When will my fix make it into a release? | Upcoming Releases |
…#35454) Summary: Pull Request resolved: #35454 Historically, we used to have hermes-executor debug and release as separate dynamic libraries. This makes it impossible to prefab this library, so I have to reconcile it into a single library. This will also help keep the setup consistent with the internal (BUCK) where we have a single target. Changelog: [Internal] [Changed] - Consolidate hermes-executor-debug and -release inside a single target Reviewed By: cipolleschi Differential Revision: D41519119 fbshipit-source-id: d9ddc30b72164daa29c735836ea433fd4d917fc8
…facebook#35454) Summary: Pull Request resolved: facebook#35454 Historically, we used to have hermes-executor debug and release as separate dynamic libraries. This makes it impossible to prefab this library, so I have to reconcile it into a single library. This will also help keep the setup consistent with the internal (BUCK) where we have a single target. Changelog: [Internal] [Changed] - Consolidate hermes-executor-debug and -release inside a single target Reviewed By: cipolleschi Differential Revision: D41519119 fbshipit-source-id: d9ddc30b72164daa29c735836ea433fd4d917fc8
Summary:
Historically, we used to have hermes-executor debug and release as separate dynamic libraries.
This makes it impossible to prefab this library, so I have to reconcile it into a single library.
This will also help keep the setup consistent with the internal (BUCK) where we have a single target.
Changelog:
[Internal] [Changed] - Consolidate hermes-executor-debug and -release inside a single target
Differential Revision: D41519119