fix(template): reference App.tsx vs App.js in template text #35377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The template has moved to typescript now, the self-reference needed an update
facebook-github-bot
added
CLA Signed
Base commit: e504141 |
|
Thanks! Missed that the filename was referenced. |
|
@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
kelset
pushed a commit
that referenced
this pull request
Nov 22, 2022
Summary: The template has moved to typescript now, the self-reference needed an update ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [GENERAL] [FIXED] - reference App.tsx vs App.js in text of new typescript template Pull Request resolved: #35377 Test Plan: It is just a text change - it either makes sense or it doesn't. I think it makes sense? Reviewed By: cipolleschi Differential Revision: D41386912 Pulled By: NickGerleman fbshipit-source-id: 6e62c11567e8fbff70b123446a827b18af43e864
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
…#35377) Summary: The template has moved to typescript now, the self-reference needed an update ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [GENERAL] [FIXED] - reference App.tsx vs App.js in text of new typescript template Pull Request resolved: facebook#35377 Test Plan: It is just a text change - it either makes sense or it doesn't. I think it makes sense? Reviewed By: cipolleschi Differential Revision: D41386912 Pulled By: NickGerleman fbshipit-source-id: 6e62c11567e8fbff70b123446a827b18af43e864
Merged
This was referenced Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The template has moved to typescript now, the self-reference needed an update
Changelog
[GENERAL] [FIXED] - reference App.tsx vs App.js in text of new typescript template
Test Plan
It is just a text change - it either makes sense or it doesn't. I think it makes sense?