Improve version checks to avoid mistakes in the versioning #35296

cipolleschi · 2022-11-09T21:44:14Z

Summary:
This change adds some version checks and enforces that every version matches some specific format based on the build type we are trying to run.

Changelog

[General][Changed] - Improve version checks

Differential Revision: D41161756

facebook-github-bot · 2022-11-09T21:45:13Z

This pull request was exported from Phabricator. Differential Revision: D41161756

…35296) Summary: Pull Request resolved: facebook#35296 This change adds some version checks and enforces that every version matches some specific format based on the build type we are trying to run. ## Changelog [General][Changed] - Improve version checks Differential Revision: D41161756 fbshipit-source-id: da7dbfbf8685f8d437a310a3c305250eb56dd89b

facebook-github-bot · 2022-11-09T21:50:18Z

This pull request was exported from Phabricator. Differential Revision: D41161756

cipolleschi · 2022-11-10T10:56:06Z

scripts/run-ci-e2e-tests.js

+  if (
+    exec(
+      'node ./scripts/set-rn-version.js --to-version 1000.0.0 --build-type dry-run',
+    ).code
+  ) {


this change makes the CircleCI test_js and test_js_prev_lts fails miserably because they can't find ruby anymore.

It doesn't make any sense to me, unless there are different scripts involved.

did you end up figuring out what was going on here? did rebasing on top of main help? 🤔

no, unfortunately. No idea why this invocation make it fail ruby... 😕

facebook-github-bot · 2022-11-10T10:57:33Z

This pull request was exported from Phabricator. Differential Revision: D41161756

analysis-bot · 2022-11-10T11:20:36Z

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	7,102,440	+0
android	hermes	armeabi-v7a	6,470,493	+0
android	hermes	x86	7,519,895	+0
android	hermes	x86_64	7,378,573	+0
android	jsc	arm64-v8a	8,967,309	+0
android	jsc	armeabi-v7a	7,698,152	+0
android	jsc	x86	9,029,418	+0
android	jsc	x86_64	9,507,263	+0

Base commit: 5dd0f73
Branch: main

…35296) Summary: Pull Request resolved: facebook#35296 This change adds some version checks and enforces that every version matches some specific format based on the build type we are trying to run. ## Changelog [General][Changed] - Improve version checks Differential Revision: D41161756 fbshipit-source-id: 10f5d22f0f1a9049397414c95f95fb8b6f5332a8

facebook-github-bot · 2022-11-10T11:31:52Z

This pull request was exported from Phabricator. Differential Revision: D41161756

analysis-bot · 2022-11-10T12:27:56Z

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: cb7f1b1
Branch: main

pull-bot · 2022-11-10T12:38:56Z

PR build artifact for 7833857 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

pull-bot · 2022-11-10T12:39:59Z

PR build artifact for 7833857 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

facebook-github-bot · 2022-11-16T16:47:09Z

This pull request was exported from Phabricator. Differential Revision: D41161756

…35296) Summary: Pull Request resolved: facebook#35296 This change adds some version checks and enforces that every version matches some specific format based on the build type we are trying to run. ## Changelog [General][Changed] - Improve version checks Differential Revision: D41161756 fbshipit-source-id: 7f4caee6a2e4fa895d33bd2ef938352cf8703d27

pull-bot · 2022-11-16T18:03:26Z

PR build artifact for 91d0401 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

pull-bot · 2022-11-16T18:03:31Z

PR build artifact for 91d0401 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

kelset

thanks for working on this - it goes in the right direction, I feel we really need to have a clear place in the code & docs that says all the potential versions and where they can be encountered.

Some comments are just questions, I think that once we've addressed it all we'll be able to merge soon.

Sorry it took me so long to loop back on this :(

scripts/bump-oss-version.js

scripts/prepare-package-for-release.js

scripts/publish-npm.js

scripts/set-rn-version.js

scripts/test-e2e-local.js

scripts/version-utils.js

kelset · 2022-11-17T17:01:39Z

scripts/version-utils.js

+function is1000_0_1(version) {
+  return (
+    version.major === '1000' && version.minor === '0' && version.patch === '1'
+  );


what is this case covering? 🤔

this: https://github.com/facebook/react-native/blob/main/.circleci/config.yml#L1646

I think we can change this, but I left it here to highlight this and let you and Nico spread some knowledge about why this value has been chosen! :D

that was not created by either of us, looks like it's coming from here e4b5d3e (and I was very much no aware of that)

soooo yeah. I guess we need to keep it around for now? It looks like it's just doing a dry run, so maybe realign it with the versioning for the dry runs? Also, the more I look at that PR, the more it feels wrong that the package_and_publish_release_dryrun is using a fixed version and not the one set in the branch :/ it means that even when we are about to publish ex. 0.71.0, the dryrun will still run with 1000.0.1 and it will basically "dry run test" something different from the final result 😅

might be worth a refactoring of that part of circleci

Ok, I tried to pick up the version from the package.json for this problem, but it can't work. The reason is that the set-rn-version script fails if we try to set the same version that is already in the package.json. That's why they used the v1000.0.1, because they were sure that it would have worked.

We can add a bit of extra logic to dry-run on a patch: this will work for dry-running on main and on stable branches. However, it won't be exact for RCs. However, for RCs, it is very hard to properly bump them: the prerelease part of the version is handled as a string (because sometimes it is a date - for the nightlies -, some other times it is the RC.x, and in the test local is something different again), so we can't actually bump the patch.

as an approximation, given that it is just a dry-run and given that we always run it with 1000.0.1, what if we accept that for RCs we dry run on a schema that is 0.X.Y-RC.K?
@kelset @cortinico

…35296) Summary: Pull Request resolved: facebook#35296 This change adds some version checks and enforces that every version matches some specific format based on the build type we are trying to run. ## Changelog [General][Changed] - Improve version checks Reviewed By: cortinico Differential Revision: D41161756 fbshipit-source-id: 39c4c7ff72e0eba5708171ec11a8a857b3d5592e

facebook-github-bot · 2022-11-18T17:45:24Z

This pull request was exported from Phabricator. Differential Revision: D41161756

pull-bot · 2022-11-18T18:15:28Z

PR build artifact for 23265e1 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

pull-bot · 2022-11-18T18:18:25Z

PR build artifact for 23265e1 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

…35296) Summary: Pull Request resolved: facebook#35296 This change adds some version checks and enforces that every version matches some specific format based on the build type we are trying to run. ## Changelog [General][Changed] - Improve version checks Reviewed By: cortinico Differential Revision: D41161756 fbshipit-source-id: fcae8101e57dbef79203881961b61d8663285fdf

facebook-github-bot · 2022-11-21T12:52:42Z

This pull request was exported from Phabricator. Differential Revision: D41161756

…35296) Summary: Pull Request resolved: facebook#35296 This change adds some version checks and enforces that every version matches some specific format based on the build type we are trying to run. ## Changelog [General][Changed] - Improve version checks Reviewed By: cortinico Differential Revision: D41161756 fbshipit-source-id: 3a889967ab6a66357d68e380409fb061f831b670

pull-bot · 2022-11-21T13:59:32Z

PR build artifact for a6880f8 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

…35296) Summary: Pull Request resolved: facebook#35296 This change adds some version checks and enforces that every version matches some specific format based on the build type we are trying to run. ## Changelog [General][Changed] - Improve version checks Reviewed By: cortinico Differential Revision: D41161756 fbshipit-source-id: aba945afc14facad9fdf7a8cc6d14542c3bf03ee

facebook-github-bot · 2022-11-21T15:14:00Z

This pull request was exported from Phabricator. Differential Revision: D41161756

kelset

pull-bot · 2022-11-21T15:45:31Z

PR build artifact for 0b3e187 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

pull-bot · 2022-11-21T15:47:21Z

PR build artifact for 0b3e187 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

Summary: Pull Request resolved: #35296 This change adds some version checks and enforces that every version matches some specific format based on the build type we are trying to run. ## Changelog [General][Changed] - Improve version checks Reviewed By: cortinico Differential Revision: D41161756 fbshipit-source-id: 4172195c5e031c1eaf7b33bb74f381c04e9adaf5

…test versioning (#35846) Summary: While working on 0.71 branch I encountered a problem in testing locally. Basically, I was getting hit by a silent error caused by recent work #35296 that didn't account for the shape of E2E local script for the release, `0.71.0-20230116-1649`. This scripts fixes both aspects: the error now gets thrown "better" and the logic accounts for the E2E shape. ## Changelog  [INTERNAL] [FIXED] - add logic for version scripts to account for local E2E test versioning Pull Request resolved: #35846 Test Plan: Tested via the other PR: #35847 Reviewed By: cortinico Differential Revision: D42543200 Pulled By: cipolleschi fbshipit-source-id: 727eb887fcbd183ec56d8a9b7e98241eaacb1d98

…35296) Summary: Pull Request resolved: facebook#35296 This change adds some version checks and enforces that every version matches some specific format based on the build type we are trying to run. ## Changelog [General][Changed] - Improve version checks Reviewed By: cortinico Differential Revision: D41161756 fbshipit-source-id: 4172195c5e031c1eaf7b33bb74f381c04e9adaf5

…test versioning (facebook#35846) Summary: While working on 0.71 branch I encountered a problem in testing locally. Basically, I was getting hit by a silent error caused by recent work facebook#35296 that didn't account for the shape of E2E local script for the release, `0.71.0-20230116-1649`. This scripts fixes both aspects: the error now gets thrown "better" and the logic accounts for the E2E shape. ## Changelog  [INTERNAL] [FIXED] - add logic for version scripts to account for local E2E test versioning Pull Request resolved: facebook#35846 Test Plan: Tested via the other PR: facebook#35847 Reviewed By: cortinico Differential Revision: D42543200 Pulled By: cipolleschi fbshipit-source-id: 727eb887fcbd183ec56d8a9b7e98241eaacb1d98

facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Nov 9, 2022

cipolleschi force-pushed the export-D41161756 branch from 461485a to dd58810 Compare November 9, 2022 21:50

cipolleschi requested a review from kelset November 9, 2022 21:56

cipolleschi commented Nov 10, 2022

View reviewed changes

cipolleschi force-pushed the export-D41161756 branch from dd58810 to 50a019c Compare November 10, 2022 10:57

cipolleschi force-pushed the export-D41161756 branch from 50a019c to 7833857 Compare November 10, 2022 11:31

cipolleschi force-pushed the export-D41161756 branch from 7833857 to 91d0401 Compare November 16, 2022 16:47

kelset suggested changes Nov 17, 2022

View reviewed changes

cipolleschi force-pushed the export-D41161756 branch from 91d0401 to 23265e1 Compare November 18, 2022 17:45

cipolleschi force-pushed the export-D41161756 branch from 680008e to 7eb2c0a Compare November 21, 2022 12:33

cipolleschi force-pushed the export-D41161756 branch from 7eb2c0a to a6880f8 Compare November 21, 2022 12:52

cipolleschi force-pushed the export-D41161756 branch from a6880f8 to 0b3e187 Compare November 21, 2022 15:14

kelset approved these changes Nov 21, 2022

View reviewed changes

facebook-github-bot closed this in f12b12c Nov 21, 2022

cipolleschi mentioned this pull request Nov 22, 2022

[LOCAL] Bypass tag check in dry run #35428

Merged

This was referenced Jan 16, 2023

fix(scripts): add logic for version scripts to account for local E2E test versioning #35846

Closed

fix(scripts): add logic for version scripts to account for local E2E test versioning #35847

Merged

cipolleschi mentioned this pull request Aug 16, 2023

cipolleschi/add maven polling #39039

Merged

cipolleschi mentioned this pull request Sep 21, 2023

[LOCAL] Copy hermes ruby files to hermes folder in local E2E test #39577

Merged

cipolleschi mentioned this pull request Oct 11, 2023

cipolleschi/fix CI #40793

Merged

cipolleschi mentioned this pull request Nov 1, 2023

[RN][CI]Update node installation on debian (0.71) #41277

Merged

This was referenced Jan 8, 2024

[0.71][RN][General] Migrate boost download url away from JFrog #42177

Merged

[RN][iOS] Fix symbol not found _jump_fcontext with use_frameworks! #42229

Merged

cipolleschi mentioned this pull request Mar 6, 2024

[RN][iOS][0.71] Fix flipper for Xcode 15.3 #43345

Merged

cipolleschi mentioned this pull request Apr 5, 2024

cipolleschi/fix yoga archive 0.71 #43895

Closed

cipolleschi mentioned this pull request Apr 26, 2024

[iOS][Privacy Manifest] Set up privacy manifest for React Native 0.71 #44281

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve version checks to avoid mistakes in the versioning #35296

Improve version checks to avoid mistakes in the versioning #35296

cipolleschi commented Nov 9, 2022

facebook-github-bot commented Nov 9, 2022

facebook-github-bot commented Nov 9, 2022

cipolleschi Nov 10, 2022 •

edited

Loading

kelset Nov 21, 2022

cipolleschi Nov 21, 2022 •

edited

Loading

facebook-github-bot commented Nov 10, 2022

analysis-bot commented Nov 10, 2022 •

edited

Loading

facebook-github-bot commented Nov 10, 2022

analysis-bot commented Nov 10, 2022 •

edited

Loading

pull-bot commented Nov 10, 2022

pull-bot commented Nov 10, 2022

facebook-github-bot commented Nov 16, 2022

pull-bot commented Nov 16, 2022

pull-bot commented Nov 16, 2022

kelset left a comment •

edited

Loading

kelset Nov 17, 2022

cipolleschi Nov 18, 2022

kelset Nov 21, 2022 •

edited

Loading

cipolleschi Nov 21, 2022

facebook-github-bot commented Nov 18, 2022

pull-bot commented Nov 18, 2022

pull-bot commented Nov 18, 2022

facebook-github-bot commented Nov 21, 2022

pull-bot commented Nov 21, 2022

facebook-github-bot commented Nov 21, 2022

kelset left a comment

pull-bot commented Nov 21, 2022

pull-bot commented Nov 21, 2022

Improve version checks to avoid mistakes in the versioning #35296

Improve version checks to avoid mistakes in the versioning #35296

Conversation

cipolleschi commented Nov 9, 2022

Changelog

facebook-github-bot commented Nov 9, 2022

facebook-github-bot commented Nov 9, 2022

cipolleschi Nov 10, 2022 • edited Loading

Choose a reason for hiding this comment

kelset Nov 21, 2022

Choose a reason for hiding this comment

cipolleschi Nov 21, 2022 • edited Loading

Choose a reason for hiding this comment

facebook-github-bot commented Nov 10, 2022

analysis-bot commented Nov 10, 2022 • edited Loading

facebook-github-bot commented Nov 10, 2022

analysis-bot commented Nov 10, 2022 • edited Loading

pull-bot commented Nov 10, 2022

pull-bot commented Nov 10, 2022

facebook-github-bot commented Nov 16, 2022

pull-bot commented Nov 16, 2022

pull-bot commented Nov 16, 2022

kelset left a comment • edited Loading

Choose a reason for hiding this comment

kelset Nov 17, 2022

Choose a reason for hiding this comment

cipolleschi Nov 18, 2022

Choose a reason for hiding this comment

kelset Nov 21, 2022 • edited Loading

Choose a reason for hiding this comment

cipolleschi Nov 21, 2022

Choose a reason for hiding this comment

facebook-github-bot commented Nov 18, 2022

pull-bot commented Nov 18, 2022

pull-bot commented Nov 18, 2022

facebook-github-bot commented Nov 21, 2022

pull-bot commented Nov 21, 2022

facebook-github-bot commented Nov 21, 2022

kelset left a comment

Choose a reason for hiding this comment

pull-bot commented Nov 21, 2022

pull-bot commented Nov 21, 2022

cipolleschi Nov 10, 2022 •

edited

Loading

cipolleschi Nov 21, 2022 •

edited

Loading

analysis-bot commented Nov 10, 2022 •

edited

Loading

analysis-bot commented Nov 10, 2022 •

edited

Loading

kelset left a comment •

edited

Loading

kelset Nov 21, 2022 •

edited

Loading