Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCTRefreshControl: Updates progressOffset behaviour to prevent it from being applied by default #35281

Closed
wants to merge 4 commits into from
+7 −0
Closed

RCTRefreshControl: Updates progressOffset behaviour to prevent it from being applied by default #35281

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b80cfb3
RCTRefreshControl: Updates progressOffset behaviour to prevent it fro…
objectivecosta Nov 9, 2022
4438584
RCTRefreshControl: Added explainer comment to clarify purpose to futu…
objectivecosta Nov 9, 2022
c035025
RCTRefreshControl: Updates condition for applying offset
objectivecosta Nov 15, 2022
bf24c9f
RCTRefreshControl: Updates _applyProgressViewOffset
objectivecosta Nov 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions React/Views/RefreshControl/RCTRefreshControl.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,13 @@ - (void)endRefreshingProgrammatically

- (void)_applyProgressViewOffset
{
// Setting the UIRefreshControl's frame breaks integration with ContentInset from the superview
// if it is a UIScrollView. This integration happens when setting the UIScrollView's .refreshControl
// property. For this reason, setting the frame manually should be avoided, if not needed.
if (_progressViewOffset == 0.f) {
return;
}

// progressViewOffset must be converted from the ScrollView parent's coordinate space to
// the coordinate space of the RefreshControl. This ensures that the control respects any
// offset in the view hierarchy, and that progressViewOffset is not inadvertently applied
Expand Down