Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abstracting Activity logic from Dev Loading View #35256

Closed
wants to merge 1 commit into from
Closed

Abstracting Activity logic from Dev Loading View #35256

wants to merge 1 commit into from

Conversation

arushikesarwani94
Copy link
Contributor

Summary:
Changelog:
[General][Added] - Making Dev Loading View cross platform by abstracting out the activity/context logic from the controller in a polymorph class.

Differential Revision: D40908923

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Nov 8, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40908923

@react-native-bot react-native-bot added the Type: Enhancement A new feature or enhancement of an existing feature. label Nov 8, 2022
@analysis-bot
Copy link

analysis-bot commented Nov 8, 2022 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,070,038 +0
android hermes armeabi-v7a 6,442,174 +0
android hermes x86 7,485,033 +0
android hermes x86_64 7,344,612 +0
android jsc arm64-v8a 8,934,550 +0
android jsc armeabi-v7a 7,668,661 +0
android jsc x86 8,994,599 +0
android jsc x86_64 9,473,532 +0

Base commit: 5744b21
Branch: main

@analysis-bot
Copy link

analysis-bot commented Nov 8, 2022 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 5744b21
Branch: main

@pull-bot
Copy link

pull-bot commented Nov 8, 2022

PR build artifact for f47a356 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@pull-bot
Copy link

pull-bot commented Nov 8, 2022

PR build artifact for f47a356 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40908923

arushikesarwani94 added a commit to arushikesarwani94/react-native that referenced this pull request Nov 9, 2022
@arushikesarwani94 @facebook-github-bot
Abstracting Activity logic from Dev Loading View (facebook#35256)
68ad30d 
Summary:
Pull Request resolved: facebook#35256

Changelog:
    [General][Added] - Making Dev Loading View cross platform by abstracting out the activity/context logic from the controller in a polymorph class.

Differential Revision: D40908923

fbshipit-source-id: ec1f249d311ed318cd0924b5fa31dc2f32e19c7b
@pull-bot
Copy link

pull-bot commented Nov 9, 2022

PR build artifact for 68ad30d is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@pull-bot
Copy link

pull-bot commented Nov 9, 2022

PR build artifact for 68ad30d is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@arushikesarwani94 @facebook-github-bot
Abstracting Activity logic from Dev Loading View (facebook#35256)
0b2c4de 
Summary:
Pull Request resolved: facebook#35256

Changelog:
    [General][Added] - Making Dev Loading View cross platform by abstracting out the activity/context logic from the controller in a polymorph class.

Differential Revision: D40908923

fbshipit-source-id: 686ad53324d9bb217630b49203c82288d64bfd7c
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40908923

@pull-bot
Copy link

pull-bot commented Nov 9, 2022

PR build artifact for 0b2c4de is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@pull-bot
Copy link

pull-bot commented Nov 9, 2022

PR build artifact for 0b2c4de is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
@arushikesarwani94 @OlimpiaZurek
Abstracting Activity logic from Dev Loading View (facebook#35256)
27bf573 
Summary:
Pull Request resolved: facebook#35256

Changelog:
    [General][Added] - Making Dev Loading View cross platform by abstracting out the activity/context logic from the controller in a polymorph class.

Reviewed By: rshest

Differential Revision: D40908923

fbshipit-source-id: db8e94f8ded5ffe0deeb88335cd7f3d1bf87243a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported p: Facebook Partner: Facebook Partner Type: Enhancement A new feature or enhancement of an existing feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@arushikesarwani94 @facebook-github-bot @analysis-bot @pull-bot @react-native-bot