Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TurboModules: Simplify React-bridging usage #35212

Closed

Conversation

christophpurrer
Copy link
Contributor

Summary:
A previous change - #34011 - already fixed basic usage of <react/bridging/.../ imports.
However that change was only tailored towards the usage of: <react/bridging/CallbackWrapper.h>

For C++ TurboModules we need to be able to access any <react/bridging/...> header via the React-Codegen CocoaPod.
Hence adding bridging now as a sub-spec to the ReactCommon CocoaPod

Changelog: [Internal]

Differential Revision: D41057878

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Nov 5, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41057878

@analysis-bot
Copy link

analysis-bot commented Nov 5, 2022

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 6,995,344 +0
android hermes armeabi-v7a 6,371,882 +0
android hermes x86 7,408,031 +0
android hermes x86_64 7,272,040 +0
android jsc arm64-v8a 8,861,159 +0
android jsc armeabi-v7a 7,599,671 +0
android jsc x86 8,918,904 +0
android jsc x86_64 9,402,268 +0

Base commit: c05e6c4
Branch: main

@pull-bot
Copy link

pull-bot commented Nov 5, 2022

PR build artifact for 8119e6c is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41057878

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Nov 5, 2022
Summary:
Pull Request resolved: facebook#35212

A previous change - facebook#34011 - already fixed basic usage of <react/bridging/.../ imports.
However that change was only tailored towards the usage of: <react/bridging/CallbackWrapper.h>

For C++ TurboModules we need to be able to access *any* <react/bridging/...> header via the React-Codegen CocoaPod.
Hence adding bridging now as a sub-spec to the ReactCommon CocoaPod

Changelog: [Internal]

Differential Revision: D41057878

fbshipit-source-id: b62308ebc7fe450092981c991a73d85b5a6e8e50
@pull-bot
Copy link

pull-bot commented Nov 5, 2022

PR build artifact for 92599be is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Nov 5, 2022
Summary:
Pull Request resolved: facebook#35212

A previous change - facebook#34011 - already fixed basic usage of <react/bridging/.../ imports.
However that change was only tailored towards the usage of: <react/bridging/CallbackWrapper.h>

For C++ TurboModules we need to be able to access *any* <react/bridging/...> header via the React-Codegen CocoaPod.
Hence adding bridging now as a sub-spec to the ReactCommon CocoaPod

Changelog: [Internal]

Differential Revision: D41057878

fbshipit-source-id: c2b5299cbdfa3be4b8590a968470f5e0338eb6e8
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41057878

@analysis-bot
Copy link

analysis-bot commented Nov 5, 2022

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: c05e6c4
Branch: main

@pull-bot
Copy link

pull-bot commented Nov 5, 2022

PR build artifact for 3b6d667 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41057878

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Nov 5, 2022
Summary:
Pull Request resolved: facebook#35212

A previous change - facebook#34011 - already fixed basic usage of <react/bridging/.../ imports.
However that change was only tailored towards the usage of: <react/bridging/CallbackWrapper.h>
Any other header besides <react/bridging/CallbackWrapper.h> from <react/bridging/... can't be imported at this in Xcode .... which is bad.

For C++ TurboModules we need to be able to access *any* <react/bridging/...> header via the React-Codegen CocoaPod.
Hence adding bridging now as a sub-spec to the ReactCommon CocoaPod

Changelog: [Internal]

Differential Revision: D41057878

fbshipit-source-id: 13995636132576cbe325473db667e45aea3cf489
@pull-bot
Copy link

pull-bot commented Nov 5, 2022

PR build artifact for 84d57fa is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

Summary:
Pull Request resolved: facebook#35212

A previous change - facebook#34011 - already fixed basic usage of <react/bridging/.../ imports.
However that change was only tailored towards the usage of: <react/bridging/CallbackWrapper.h>
Any other header besides <react/bridging/CallbackWrapper.h> from <react/bridging/... can't be imported at this time in Xcode ... ... which is bad.

For C++ TurboModules we need to be able to access *any* <react/bridging/...> header via the React-Codegen CocoaPod.
Hence adding bridging now as a sub-spec to the ReactCommon CocoaPod

Changelog: [Internal]

Differential Revision: D41057878

fbshipit-source-id: 9125933c3590ac26ea51c66c5fd8d1a215e9f0d8
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41057878

@pull-bot
Copy link

pull-bot commented Nov 7, 2022

PR build artifact for f5fed4d is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @christophpurrer in 7203187.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Nov 7, 2022
kelset pushed a commit that referenced this pull request Nov 22, 2022
Summary:
Pull Request resolved: #35212

A previous change - #34011 - already fixed basic usage of <react/bridging/.../ imports.
However that change was only tailored towards the usage of: <react/bridging/CallbackWrapper.h>
Any other header besides <react/bridging/CallbackWrapper.h> from <react/bridging/... can't be imported at this time in Xcode ... ... which is bad.

For C++ TurboModules we need to be able to access *any* <react/bridging/...> header via the React-Codegen CocoaPod.
Hence adding bridging now as a sub-spec to the ReactCommon CocoaPod

Changelog: [Internal]

Reviewed By: cipolleschi

Differential Revision: D41057878

fbshipit-source-id: 83c117bc5252d84dd419cdb72f145f65547d23b2

# Conflicts:
#	scripts/cocoapods/__tests__/codegen_utils-test.rb
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
Summary:
Pull Request resolved: facebook#35212

A previous change - facebook#34011 - already fixed basic usage of <react/bridging/.../ imports.
However that change was only tailored towards the usage of: <react/bridging/CallbackWrapper.h>
Any other header besides <react/bridging/CallbackWrapper.h> from <react/bridging/... can't be imported at this time in Xcode ... ... which is bad.

For C++ TurboModules we need to be able to access *any* <react/bridging/...> header via the React-Codegen CocoaPod.
Hence adding bridging now as a sub-spec to the ReactCommon CocoaPod

Changelog: [Internal]

Reviewed By: cipolleschi

Differential Revision: D41057878

fbshipit-source-id: 83c117bc5252d84dd419cdb72f145f65547d23b2
@cipolleschi cipolleschi mentioned this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants