Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rn tester app): change appearence example to hooks #35114

Conversation

Marcoo09
Copy link
Contributor

@Marcoo09 Marcoo09 commented Oct 28, 2022

Summary

This pull request migrates the appearance example to using React Hooks.

Changelog

[General] [Changed] - RNTester: Migrate Appearence to hooks

Test Plan

The animation works exactly as it did as when it was a class component

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 28, 2022
@analysis-bot
Copy link

analysis-bot commented Oct 28, 2022

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,003,068 -282
android hermes armeabi-v7a 6,379,407 -288
android hermes x86 7,415,908 -278
android hermes x86_64 7,279,811 -282
android jsc arm64-v8a 8,868,151 -195
android jsc armeabi-v7a 7,606,471 -181
android jsc x86 8,926,057 -175
android jsc x86_64 9,409,292 -181

Base commit: 87d6580
Branch: main

@analysis-bot
Copy link

analysis-bot commented Oct 28, 2022

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 87d6580
Branch: main

@pull-bot
Copy link

PR build artifact for 95d8817 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@cipolleschi
Copy link
Contributor

Hi @Marcoo09, thanks for doing this.
There are several JS jobs that are failing. Can you have a look at them and fix them?

When the CI is green, we can import this.

@pull-bot
Copy link

PR build artifact for ab94909 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @Marcoo09 in 22576fa.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Nov 28, 2022
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
…#35114)

Summary:
This pull request migrates the appearance example to using React Hooks.

## Changelog
[General] [Changed] - RNTester: Migrate Appearence to hooks

Pull Request resolved: facebook#35114

Test Plan: The animation works exactly as it did as when it was a class component

Reviewed By: cortinico

Differential Revision: D41531005

Pulled By: cipolleschi

fbshipit-source-id: a864766a3bb58a7f0c2b9c4ed8f731ee84713b26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants