Always generate an EmptyNativeState #34750
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D39509869 |
react-native-bot
added
the
Type: Enhancement
Base commit: eddff32 |
Base commit: 6ba5fa9 |
|
This pull request was exported from Phabricator. Differential Revision: D39509869 |
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 21, 2022
Summary: Pull Request resolved: facebook#34750 This Diff is the first step of enabling the CodeGen to parse and generate a NativeState for the components. The feature has been largely requested by the OSS community but it could be also helpful for people in Meta. To make this work, we also have to always generate a ViewEventEmitter: that's because the ConcreteShadowNode template lists the Generics with this order: Name, Props, EventEmitter, Others... If we skip the EventEmitters and we put the State, React Native would think that the State is actually an EventEmitter and the build step will fail. ## Changelog [General][Added] - Always generate an empty NativeState for Fabric Components Differential Revision: D39509869 fbshipit-source-id: 93eb8b6d280e4ae95dd32f578e181d22fed781b5
cipolleschi
force-pushed
the
export-D39509869
branch
from
78ec0e5 to
f29ead8
Compare
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 21, 2022
Summary: Pull Request resolved: facebook#34750 This Diff is the first step of enabling the CodeGen to parse and generate a NativeState for the components. The feature has been largely requested by the OSS community but it could be also helpful for people in Meta. To make this work, we also have to always generate a ViewEventEmitter: that's because the ConcreteShadowNode template lists the Generics with this order: Name, Props, EventEmitter, Others... If we skip the EventEmitters and we put the State, React Native would think that the State is actually an EventEmitter and the build step will fail. ## Changelog [General][Added] - Always generate an empty NativeState for Fabric Components Differential Revision: D39509869 fbshipit-source-id: 0c83443b185c49339a456caea1feba6023f8e1df
cipolleschi
force-pushed
the
export-D39509869
branch
from
f29ead8 to
b9057c1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D39509869 |
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 21, 2022
Summary: Pull Request resolved: facebook#34750 This Diff is the first step of enabling the CodeGen to parse and generate a NativeState for the components. The feature has been largely requested by the OSS community but it could be also helpful for people in Meta. To make this work, we also have to always generate a ViewEventEmitter: that's because the ConcreteShadowNode template lists the Generics with this order: Name, Props, EventEmitter, Others... If we skip the EventEmitters and we put the State, React Native would think that the State is actually an EventEmitter and the build step will fail. ## Changelog [General][Added] - Always generate an empty NativeState for Fabric Components Differential Revision: https://www.internalfb.com/diff/D39509869?entry_point=27 fbshipit-source-id: d1112d15c26e01db5af231cee65bb2fe094251ca
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 21, 2022
Summary: Pull Request resolved: facebook#34750 This Diff is the first step of enabling the CodeGen to parse and generate a NativeState for the components. The feature has been largely requested by the OSS community but it could be also helpful for people in Meta. To make this work, we also have to always generate a ViewEventEmitter: that's because the ConcreteShadowNode template lists the Generics with this order: Name, Props, EventEmitter, Others... If we skip the EventEmitters and we put the State, React Native would think that the State is actually an EventEmitter and the build step will fail. ## Changelog [General][Added] - Always generate an empty NativeState for Fabric Components Differential Revision: https://www.internalfb.com/diff/D39509869?entry_point=27 fbshipit-source-id: 32a7924ff1079578cb43d4b757adb0f3cb097593
|
This pull request was exported from Phabricator. Differential Revision: D39509869 |
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 21, 2022
Summary: Pull Request resolved: facebook#34750 This Diff is the first step of enabling the CodeGen to parse and generate a NativeState for the components. The feature has been largely requested by the OSS community but it could be also helpful for people in Meta. To allow the generation of custom `NativeState`, we first have to always generate a `ViewEventEmitter`: that's because the `ConcreteShadowNode` template lists the Generics with this order: `Name`, `Props`, `EventEmitter`, Others... If we skip the `EventEmitters` and we put the `State`, React Native would think that the State is actually an `EventEmitter` and the build step will fail. ## Changelog [General][Added] - Always generate a ViewEventEmitter for Fabric Components Differential Revision: D39509869 fbshipit-source-id: 507092d7acaf3fe6d9920327145e9c70f706281d
cipolleschi
force-pushed
the
export-D39509869
branch
from
b9057c1 to
b4f5378
Compare
Summary: Pull Request resolved: facebook#34750 This Diff is the first step of enabling the CodeGen to parse and generate a NativeState for the components. The feature has been largely requested by the OSS community but it could be also helpful for people in Meta. To allow the generation of custom `NativeState`, we first have to always generate a `ViewEventEmitter`: that's because the `ConcreteShadowNode` template lists the Generics with this order: `Name`, `Props`, `EventEmitter`, Others... If we skip the `EventEmitters` and we put the `State`, React Native would think that the State is actually an `EventEmitter` and the build step will fail. ## Changelog [General][Added] - Always generate a ViewEventEmitter for Fabric Components Differential Revision: D39509869 fbshipit-source-id: c5d10a7cc3dec06ed8c91f523c141c439b524bdd
|
This pull request was exported from Phabricator. Differential Revision: D39509869 |
cipolleschi
force-pushed
the
export-D39509869
branch
from
b4f5378 to
9383b6d
Compare
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 21, 2022
Summary: Pull Request resolved: facebook#34750 This Diff is the first step of enabling the CodeGen to parse and generate a NativeState for the components. The feature has been largely requested by the OSS community but it could be also helpful for people in Meta. To allow the generation of custom `NativeState`, we first have to always generate a `ViewEventEmitter`: that's because the `ConcreteShadowNode` template lists the Generics with this order: `Name`, `Props`, `EventEmitter`, Others... If we skip the `EventEmitters` and we put the `State`, React Native would think that the State is actually an `EventEmitter` and the build step will fail. ## Changelog [General][Added] - Always generate a ViewEventEmitter for Fabric Components Differential Revision: https://internalfb.com/D39509869 fbshipit-source-id: 658e1ccfe74a6649f56ca62836ba23eb9314f120
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 21, 2022
Summary: Pull Request resolved: facebook#34750 This Diff is the first step of enabling the CodeGen to parse and generate a NativeState for the components. The feature has been largely requested by the OSS community but it could be also helpful for people in Meta. To allow the generation of custom `NativeState`, we first have to always generate a `ViewEventEmitter`: that's because the `ConcreteShadowNode` template lists the Generics with this order: `Name`, `Props`, `EventEmitter`, Others... If we skip the `EventEmitters` and we put the `State`, React Native would think that the State is actually an `EventEmitter` and the build step will fail. ## Changelog [General][Added] - Always generate a ViewEventEmitter for Fabric Components Differential Revision: https://internalfb.com/D39509869 fbshipit-source-id: db5a466e7c810f0949631759dae67468f4cfe364
|
This pull request was successfully merged by @cipolleschi in 69f8cf1. When will my fix make it into a release? | Upcoming Releases |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Pull Request resolved: facebook#34750 This Diff is the first step of enabling the CodeGen to parse and generate a NativeState for the components. The feature has been largely requested by the OSS community but it could be also helpful for people in Meta. To allow the generation of custom `NativeState`, we first have to always generate a `ViewEventEmitter`: that's because the `ConcreteShadowNode` template lists the Generics with this order: `Name`, `Props`, `EventEmitter`, Others... If we skip the `EventEmitters` and we put the `State`, React Native would think that the State is actually an `EventEmitter` and the build step will fail. ## Changelog [General][Added] - Always generate a ViewEventEmitter for Fabric Components Reviewed By: cortinico Differential Revision: D39509869 fbshipit-source-id: 390cc146ef013baf1ed09d55a0182a5aeb5b9d9e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This Diff is the first step of enabling the CodeGen to parse and generate a NativeState for the components.
The feature has been largely requested by the OSS community but it could be also helpful for people in Meta.
To make this work, we also have to always generate a ViewEventEmitter: that's because the ConcreteShadowNode template lists the Generics with this order: Name, Props, EventEmitter, Others...
If we skip the EventEmitters and we put the State, React Native would think that the State is actually an EventEmitter and the build step will fail.
Changelog
[General][Added] - Always generate an empty NativeState for Fabric Components
Differential Revision: D39509869