-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: rename polyfills to js-polyfills (umbrella 480) #34574
Conversation
Base commit: 2d1d61a |
Base commit: 2d1d61a |
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
packages/js-polyfills/BUCK
Outdated
@@ -21,8 +21,8 @@ yarn_workspace( | |||
) | |||
|
|||
rn_library( | |||
name = "polyfills", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commenting here but valid for the whole PR:
Let's undo the BUCK update and the path change. It will make easier for us to import and merge this change 👍
I've also posted an update on the monorepo effort there:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done ✅
BUCK
Outdated
@@ -770,7 +770,7 @@ rn_library( | |||
"//xplat/js/RKJSModules/vendor/scheduler:scheduler", | |||
"//xplat/js/react-native-github/packages/assets:assets", | |||
"//xplat/js/react-native-github/packages/normalize-color:normalize-color", | |||
"//xplat/js/react-native-github/packages/polyfills:polyfills", | |||
"//xplat/js/react-native-github/packages/js-polyfills:polyfills", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be reverted
packages/js-polyfills/package.json
Outdated
"description": "Polyfills for React Native.", | ||
"repository": { | ||
"type": "git", | ||
"url": "[email protected]:facebook/react-native.git", | ||
"directory": "packages/polyfills" | ||
"directory": "packages/js-polyfills" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be reverted, alognisde the path renaming
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
/rebase |
@Titozzz can you manually rebase this. We can't use /rebase here as this is older |
@hoxyq do what you have to do 👍 lmk if I can help |
75c946c
to
57cb25b
Compare
57cb25b
to
04943ae
Compare
PR build artifact for 04943ae is ready. |
PR build artifact for 04943ae is ready. |
@hoxyq has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This pull request was successfully merged by @Titozzz in ca1ae5c. When will my fix make it into a release? | Upcoming Releases |
This pull request has been reverted by 6e9d3bf. |
Summary: ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [General] [Changed] - Rename polyfills to js-polyfills as part of react-native-community/discussions-and-proposals#480 Pull Request resolved: facebook#34574 Reviewed By: cipolleschi Differential Revision: D39268818 Pulled By: hoxyq fbshipit-source-id: c87807460f27fc83667d18c350a4a847459f056e
Summary
Changelog
[General] [Changed] - Rename polyfills to js-polyfills as part of react-native-community/discussions-and-proposals#480
Test Plan