Make sure *.ts files are considered for task avoidance in the Gradle Plugin #34296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Base commit: 1ce23ce |
|
This pull request was successfully merged by @cortinico in 1a9fb6c. When will my fix make it into a release? | Upcoming Releases |
|
@cortinico I just stumbled upon this randomly. Quick question: Shouldn't it also include |
Not really as spec files should not use jsx/tsx |
kelset
pushed a commit
that referenced
this pull request
Aug 2, 2022
…Plugin (#34296) Summary: I've realized that the gradle plugin is currently looking at `.js` files for task re-execution. This means that, while the *.ts would still be considered when the codegen is invoked, an edit on one of those file, won't retrigger the codegen on Android. This change fixes it so that we consider both `*.ts` and `*.js` files. ## Changelog [Android] [Fixed] - Make sure *.ts files are considered for task avoidance in the Gradle Plugin Pull Request resolved: #34296 Test Plan: Tests are attached. Reviewed By: cipolleschi Differential Revision: D38246125 Pulled By: cortinico fbshipit-source-id: 80efcc9ef747c598ca040d65b25d270593c8aed2
roryabraham
pushed a commit
to Expensify/react-native
that referenced
this pull request
Aug 17, 2022
…Plugin (facebook#34296) Summary: I've realized that the gradle plugin is currently looking at `.js` files for task re-execution. This means that, while the *.ts would still be considered when the codegen is invoked, an edit on one of those file, won't retrigger the codegen on Android. This change fixes it so that we consider both `*.ts` and `*.js` files. ## Changelog [Android] [Fixed] - Make sure *.ts files are considered for task avoidance in the Gradle Plugin Pull Request resolved: facebook#34296 Test Plan: Tests are attached. Reviewed By: cipolleschi Differential Revision: D38246125 Pulled By: cortinico fbshipit-source-id: 80efcc9ef747c598ca040d65b25d270593c8aed2
roryabraham
pushed a commit
to Expensify/react-native
that referenced
this pull request
Aug 17, 2022
…Plugin (facebook#34296) Summary: I've realized that the gradle plugin is currently looking at `.js` files for task re-execution. This means that, while the *.ts would still be considered when the codegen is invoked, an edit on one of those file, won't retrigger the codegen on Android. This change fixes it so that we consider both `*.ts` and `*.js` files. ## Changelog [Android] [Fixed] - Make sure *.ts files are considered for task avoidance in the Gradle Plugin Pull Request resolved: facebook#34296 Test Plan: Tests are attached. Reviewed By: cipolleschi Differential Revision: D38246125 Pulled By: cortinico fbshipit-source-id: 80efcc9ef747c598ca040d65b25d270593c8aed2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I've realized that the gradle plugin is currently looking at
.jsfiles for task re-execution. This means that, while the *.ts would still be considered when the codegen is invoked, an edit on one of those file, won't retrigger the codegen on Android.This change fixes it so that we consider both
*.tsand*.jsfiles.Changelog
[Android] [Fixed] - Make sure *.ts files are considered for task avoidance in the Gradle Plugin
Test Plan
Tests are attached.