Fix test-manual-e2e on Android/Hermes for New App Template #34294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Base commit: 3f50440 |
|
This pull request was successfully merged by @cortinico in 1ce23ce. When will my fix make it into a release? | Upcoming Releases |
kelset
pushed a commit
that referenced
this pull request
Aug 2, 2022
Summary: The current `test-manual-e2e.sh` script is broken on Android + Hermes + New App Template. This commit fixes it. Specifically: - There is no need to generate Maven Artifacts for RN Tester, as RN Tester consumes them from source. - There is instead a need to generate Maven Artifacts for New App Template, as they need to be included inside the NPM package. - The `:ReactAndroid:hermes-engine:installArchives` task needs to invoked to also generate the Hermes-engine .aar for bundling. ## Changelog [Internal] - Fix test-manual-e2e on Android/Hermes for New App Template Pull Request resolved: #34294 Test Plan: I've tested this against the `0.70-stable` branch and I was able to run an App from the New Template properly. Reviewed By: dmitryrykun Differential Revision: D38239238 Pulled By: cortinico fbshipit-source-id: b3d95bad21515b12a91e29147e70ba8323896660
roryabraham
pushed a commit
to Expensify/react-native
that referenced
this pull request
Aug 17, 2022
…34294) Summary: The current `test-manual-e2e.sh` script is broken on Android + Hermes + New App Template. This commit fixes it. Specifically: - There is no need to generate Maven Artifacts for RN Tester, as RN Tester consumes them from source. - There is instead a need to generate Maven Artifacts for New App Template, as they need to be included inside the NPM package. - The `:ReactAndroid:hermes-engine:installArchives` task needs to invoked to also generate the Hermes-engine .aar for bundling. ## Changelog [Internal] - Fix test-manual-e2e on Android/Hermes for New App Template Pull Request resolved: facebook#34294 Test Plan: I've tested this against the `0.70-stable` branch and I was able to run an App from the New Template properly. Reviewed By: dmitryrykun Differential Revision: D38239238 Pulled By: cortinico fbshipit-source-id: b3d95bad21515b12a91e29147e70ba8323896660
roryabraham
pushed a commit
to Expensify/react-native
that referenced
this pull request
Aug 17, 2022
…34294) Summary: The current `test-manual-e2e.sh` script is broken on Android + Hermes + New App Template. This commit fixes it. Specifically: - There is no need to generate Maven Artifacts for RN Tester, as RN Tester consumes them from source. - There is instead a need to generate Maven Artifacts for New App Template, as they need to be included inside the NPM package. - The `:ReactAndroid:hermes-engine:installArchives` task needs to invoked to also generate the Hermes-engine .aar for bundling. ## Changelog [Internal] - Fix test-manual-e2e on Android/Hermes for New App Template Pull Request resolved: facebook#34294 Test Plan: I've tested this against the `0.70-stable` branch and I was able to run an App from the New Template properly. Reviewed By: dmitryrykun Differential Revision: D38239238 Pulled By: cortinico fbshipit-source-id: b3d95bad21515b12a91e29147e70ba8323896660
kelset
pushed a commit
that referenced
this pull request
Aug 25, 2022
Summary: The current `test-manual-e2e.sh` script is broken on Android + Hermes + New App Template. This commit fixes it. Specifically: - There is no need to generate Maven Artifacts for RN Tester, as RN Tester consumes them from source. - There is instead a need to generate Maven Artifacts for New App Template, as they need to be included inside the NPM package. - The `:ReactAndroid:hermes-engine:installArchives` task needs to invoked to also generate the Hermes-engine .aar for bundling. ## Changelog [Internal] - Fix test-manual-e2e on Android/Hermes for New App Template Pull Request resolved: #34294 Test Plan: I've tested this against the `0.70-stable` branch and I was able to run an App from the New Template properly. Reviewed By: dmitryrykun Differential Revision: D38239238 Pulled By: cortinico fbshipit-source-id: b3d95bad21515b12a91e29147e70ba8323896660
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The current
test-manual-e2e.shscript is broken on Android + Hermes + New App Template.This commit fixes it. Specifically:
:ReactAndroid:hermes-engine:installArchivestask needs to invoked to also generate the Hermes-engine .aar for bundling.Changelog
[Internal] - Fix test-manual-e2e on Android/Hermes for New App Template
Test Plan
I've tested this against the
0.70-stablebranch and I was able to run an App from the New Template properly.