Improve OSS systrace #34252
Closed
Improve OSS systrace #34252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
react-native-bot
added
Platform: Android
Base commit: a67360b |
janicduplessis
commented
Jul 23, 2022
| public final class SystraceMessage { | ||
|
|
||
| private static final Builder NOOP_BUILDER = new NoopBuilder(); | ||
| public static Boolean INCLUDE_ARGS = false; |
There was a problem hiding this comment.
Adding arguments to the section name makes grouping similar events a lot harder so by default I disable it. I don't really see how else args are useful for systrace in Android Studio. How is that used internally at facebook?
facebook-github-bot
added
the
Shared with Meta
Base commit: a67360b |
|
@dmitryrykun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cortinico
reviewed
Jul 27, 2022
| @@ -24,6 +24,7 @@ PROGUARD_ANNOTATIONS_VERSION=1.19.0 | |||
| ROBOLECTRIC_VERSION=4.4 | |||
| SO_LOADER_VERSION=0.10.4 | |||
| SWIPEREFRESH_LAYOUT_VERSION=1.0.0 | |||
| ANDROIDX_TRACING_VERSION=1.1.0 | |||
There was a problem hiding this comment.
nit: can we keep this sorted?
|
This pull request was successfully merged by @janicduplessis in ccbfdd7. When will my fix make it into a release? | Upcoming Releases |
roryabraham
pushed a commit
to Expensify/react-native
that referenced
this pull request
Aug 17, 2022
Summary: Implements most of systrace using androidx.tracing, this makes it usable using Android Studio profiler systrace. ## Changelog [Android] [Added] - Improve OSS systrace Pull Request resolved: facebook#34252 Test Plan: Run a systrace in Android Studio for RN Tester and make sure RN specific sections are there. <img width="1263" alt="image" src="https://user-images.githubusercontent.com/2677334/180593493-fc087b4a-2253-43e1-b246-bed3e7bba7ac.png"> Reviewed By: NickGerleman Differential Revision: D38116890 Pulled By: dmitryrykun fbshipit-source-id: 744bedbf9ad4004488340a5b4e93d936d9a1e582
roryabraham
pushed a commit
to Expensify/react-native
that referenced
this pull request
Aug 17, 2022
Summary: Implements most of systrace using androidx.tracing, this makes it usable using Android Studio profiler systrace. ## Changelog [Android] [Added] - Improve OSS systrace Pull Request resolved: facebook#34252 Test Plan: Run a systrace in Android Studio for RN Tester and make sure RN specific sections are there. <img width="1263" alt="image" src="https://user-images.githubusercontent.com/2677334/180593493-fc087b4a-2253-43e1-b246-bed3e7bba7ac.png"> Reviewed By: NickGerleman Differential Revision: D38116890 Pulled By: dmitryrykun fbshipit-source-id: 744bedbf9ad4004488340a5b4e93d936d9a1e582
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements most of systrace using androidx.tracing, this makes it usable using Android Studio profiler systrace.
Changelog
[Android] [Added] - Improve OSS systrace
Test Plan
Run a systrace in Android Studio for RN Tester and make sure RN specific sections are there.