Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Hermes pod: change logic to use the hermes tag to set the pod source correctly #34221

Closed
wants to merge 4 commits into from
+3 −1
Closed

[fix] Hermes pod: change logic to use the hermes tag to set the pod source correctly #34221

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2d54e2e
change logic to use the hermes tag to set the pod correctly
kelset Jul 19, 2022
61785f9
change from :commit to :tag
kelset Jul 19, 2022
0aa3f8b
cleanup
kelset Jul 19, 2022
8c1bbd0
add strip
kelset Jul 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion sdks/hermes-engine/hermes-engine.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,10 @@ elsif version == '1000.0.0'
source[:commit] = `git ls-remote https://github.com/facebook/hermes main | cut -f 1`.strip
elsif currentremote.strip.end_with?("facebook/react-native.git") and currentbranch.strip.end_with?("-stable")
Pod::UI.puts '[Hermes] Detected that you are on a React Native release branch, building Hermes from source...'.yellow if Object.const_defined?("Pod::UI")
hermestag_file = File.join(__dir__, "..", ".hermesversion")
hermestag = File.read(hermestag_file)
source[:git] = git
source[:commit] = `git ls-remote https://github.com/facebook/hermes main | cut -f 1`.strip
source[:commit] = `git ls-remote https://github.com/facebook/hermes #{hermestag} | cut -f 1`.strip
kelset marked this conversation as resolved.
Show resolved Hide resolved
else
source[:http] = "https://github.com/facebook/react-native/releases/download/v#{version}/hermes-runtime-darwin-v#{version}.tar.gz"
end
Expand Down