Remove the isTVOS check #34071
Closed
Remove the isTVOS check #34071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Base commit: d666eb7 |
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Base commit: d666eb7 |
|
This pull request was successfully merged by @Zachinquarantine in 6075d64. When will my fix make it into a release? | Upcoming Releases |
1 task
kkafar
added a commit
to software-mansion/react-native-screens
that referenced
this pull request
Oct 3, 2022
## Description Fixes #1604 `Platform.isTVOS` check was removed with `[email protected]` [(see the PR)](facebook/react-native#34071) as it was only wrapper for `Platform.isTV` check (which exists since `0.61`). ## Changes Dropped usage of removed `Platform.isTVOS` check in favour of `Platform.isTV`. ## Test code and steps to reproduce See #1604 -- check on any app that the library now works with `@types/[email protected].*` ## Checklist - [x] Ensured that CI passes
kacperkapusciak
pushed a commit
to react-navigation/react-navigation
that referenced
this pull request
Nov 7, 2022
**Motivation** This PR supersedes a deprecated `Platform.isTVOS` which got removed in facebook/react-native#34071 for the currently used standard - a `Platform.isTV` check. `Platform.isTV` check exists since react-native `v0.61` that way no breaking changes are introduced to react-navigation. Ref: software-mansion/react-native-screens#1605
kacperkapusciak
pushed a commit
to josemak25/react-navigation
that referenced
this pull request
Dec 15, 2022
) **Motivation** This PR supersedes a deprecated `Platform.isTVOS` which got removed in facebook/react-native#34071 for the currently used standard - a `Platform.isTV` check. `Platform.isTV` check exists since react-native `v0.61` that way no breaking changes are introduced to react-navigation. Ref: software-mansion/react-native-screens#1605
mccoyplayer
pushed a commit
to mccoyplayer/reactScreen
that referenced
this pull request
Feb 9, 2024
## Description Fixes #1604 `Platform.isTVOS` check was removed with `[email protected]` [(see the PR)](facebook/react-native#34071) as it was only wrapper for `Platform.isTV` check (which exists since `0.61`). ## Changes Dropped usage of removed `Platform.isTVOS` check in favour of `Platform.isTV`. ## Test code and steps to reproduce See #1604 -- check on any app that the library now works with `@types/[email protected].*` ## Checklist - [x] Ensured that CI passes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
isTVOScheck, which just duplicated and returned theisTVcheck anyway.Changelog
[General] [Removed] - Remove deprecated
isTVOSconstant.Test Plan
Run against CI, and apply changes as needed.