Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix keyboard staying as email when switching between default and email #33924

Closed
wants to merge 2 commits into from
Closed

Fix keyboard staying as email when switching between default and email #33924

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3124d5
Fix keyboard staying as email when switching between default and email
larkox May 27, 2022
e8182cf
Merge branch 'main' into FixKeyboardSwitch
larkox Jun 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactTextInputManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,13 @@ public class ReactTextInputManager extends BaseViewManager<ReactEditText, Layout
InputType.TYPE_TEXT_FLAG_CAP_SENTENCES
| InputType.TYPE_TEXT_FLAG_CAP_WORDS
| InputType.TYPE_TEXT_FLAG_CAP_CHARACTERS;
private static final int INPUT_TYPE_CLEAR =
InputType.TYPE_MASK_CLASS
| InputType.TYPE_NUMBER_FLAG_SIGNED
| InputType.TYPE_NUMBER_FLAG_DECIMAL
| InputType.TYPE_TEXT_VARIATION_EMAIL_ADDRESS
| InputType.TYPE_TEXT_VARIATION_VISIBLE_PASSWORD
| InputType.TYPE_TEXT_VARIATION_URI;

private static final String KEYBOARD_TYPE_EMAIL_ADDRESS = "email-address";
private static final String KEYBOARD_TYPE_NUMERIC = "numeric";
Expand Down Expand Up @@ -855,7 +862,7 @@ public void setKeyboardType(ReactEditText view, @Nullable String keyboardType) {
flagsToSet = InputType.TYPE_TEXT_VARIATION_URI;
}

updateStagedInputTypeFlag(view, InputType.TYPE_MASK_CLASS, flagsToSet);
updateStagedInputTypeFlag(view, INPUT_TYPE_CLEAR, flagsToSet);
checkPasswordType(view);
}

Expand Down