Fix hermes compilation in the react-native package
#33881
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
fortmarek
changed the title
react-native package
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Base commit: 291f26c |
|
This pull request was successfully merged by @fortmarek in 841793a. When will my fix make it into a release? | Upcoming Releases |
|
Ooof, thank you for fixing this! |
fortmarek
added a commit
that referenced
this pull request
May 24, 2022
Summary: When releasing the latest RC, we have noticed `pod install` is broken since the downloaded `react-native` package is missing hermes scripts and `shelljs` dependency (needed by `hermes-utils.js`). ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [Internal] - Fix compiling hermes in the release version. Pull Request resolved: #33881 Test Plan: - Run `test-manual-e2e.sh` with template and Hermes on iOS Reviewed By: GijsWeterings Differential Revision: D36546116 Pulled By: cortinico fbshipit-source-id: 70fe70de7d63193df888b8ece935c4fa97b4dfc8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When releasing the latest RC, we have noticed
pod installis broken since the downloadedreact-nativepackage is missing hermes scripts andshelljsdependency (needed byhermes-utils.js).Changelog
[Internal] - Fix compiling hermes in the release version.
Test Plan
test-manual-e2e.shwith template and Hermes on iOS