-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create script to automatically set CLANG_CXX_LANGUAGE_STANDARD on the client project #33863
Conversation
@f-meloni has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@f-meloni has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@f-meloni has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Base commit: 05aaba9 |
Base commit: 05aaba9 |
@f-meloni has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
@f-meloni has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
…new_architecture_ruby_script
@f-meloni has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@f-meloni has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This pull request was successfully merged by @f-meloni in ca8174e. When will my fix make it into a release? | Upcoming Releases |
Summary
Currently this section of the Playbook tells us to set CLANG_CXX_LANGUAGE_STANDARD = "c++17" in the main app target for the new architecture to work.
Would be nice to be able to automate that instead
Changelog
[iOS] [Added] - Cocoapods function to add the
CLANG_CXX_LANGUAGE_STANDARD
to all the targets if neededTest Plan
I've created some unit tests for the newly added function.
I've executed pod install and the ruby tests locally.