Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create script to automatically set CLANG_CXX_LANGUAGE_STANDARD on the client project #33863

Closed
wants to merge 7 commits into from

Conversation

f-meloni
Copy link
Contributor

Summary

Currently this section of the Playbook tells us to set CLANG_CXX_LANGUAGE_STANDARD = "c++17" in the main app target for the new architecture to work.
Would be nice to be able to automate that instead

Changelog

[iOS] [Added] - Cocoapods function to add the CLANG_CXX_LANGUAGE_STANDARD to all the targets if needed

Test Plan

I've created some unit tests for the newly added function.
I've executed pod install and the ruby tests locally.

@f-meloni f-meloni requested a review from hramos as a code owner May 18, 2022 17:35
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels May 18, 2022
@facebook-github-bot
Copy link
Contributor

@f-meloni has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@react-native-bot react-native-bot added Platform: iOS iOS applications. Type: Enhancement A new feature or enhancement of an existing feature. labels May 18, 2022
@facebook-github-bot
Copy link
Contributor

@f-meloni has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@f-meloni has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@analysis-bot
Copy link

analysis-bot commented May 19, 2022

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 05aaba9
Branch: main

@analysis-bot
Copy link

analysis-bot commented May 19, 2022

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,782,987 +0
android hermes armeabi-v7a 7,186,490 +0
android hermes x86 8,094,636 +0
android hermes x86_64 8,072,077 +0
android jsc arm64-v8a 9,655,567 +0
android jsc armeabi-v7a 8,427,832 +0
android jsc x86 9,607,819 +0
android jsc x86_64 10,202,447 +0

Base commit: 05aaba9
Branch: main

@facebook-github-bot
Copy link
Contributor

@f-meloni has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

1 similar comment
@facebook-github-bot
Copy link
Contributor

@f-meloni has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@f-meloni has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@f-meloni has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @f-meloni in ca8174e.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label May 19, 2022
@yungsters yungsters deleted the new_architecture_ruby_script branch August 12, 2022 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Facebook Partner: Facebook Partner Platform: iOS iOS applications. Type: Enhancement A new feature or enhancement of an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants