-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pod install --project-directory=ios
failing when Hermes is enabled
#33820
Conversation
# Use React Native's own scripts to build Hermes | ||
system("cp #{sdks_dir}/hermes-engine/hermes-engine.podspec #{hermes_dir}/hermes-engine.podspec") | ||
system("cp #{sdks_dir}/hermes-engine/utils/* #{hermes_dir}/utils/.") | ||
FileUtils.cp(sdks_dir.join("hermes-engine", "hermes-engine.podspec"), hermes_dir.join("hermes-engine.podspec")) | ||
FileUtils.cp_r(sdks_dir.join("hermes-engine", "utils"), hermes_dir) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section changed since the 0.69 cut. The PR for 0.69 is here: #33819
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks I've tracked this 👍
For context, what's the failure? |
Base commit: a897314 |
Sorry, forgot to add the error message here. I posted it over here: reactwg/react-native-releases#21 (comment). In any case, I've updated the PR description. |
@cortinico: It looks like this code was removed in favour of a JS script. I'm closing this PR, but the one for |
Summary
pod install --project-directory=ios
fails when Hermes is enabled:Changelog
[iOS] [Fixed] -
pod install --project-directory=ios
fails when Hermes is enabledTest Plan
Running
pod install --project-directory=ios
is enough to trigger this issue.