Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce Gemfile, ruby-version #32303

Closed
wants to merge 7 commits into from
Closed

Introduce Gemfile, ruby-version #32303

wants to merge 7 commits into from

Commits on Oct 1, 2021

  1. Provide template/Gemfile with recommended Ruby and CocoaPods 

    The Gemfile is used by https://bundler.io/ to install and use tools
with the correct version and environment.

The scripts/update-ruby.sh will take care to update ruby-version and
related files, including the Gemfile and Gemfile.lock

These files are added to git staging (git add)
    @barbieri
    barbieri committed Oct 1, 2021
    Configuration menu
    Copy the full SHA
    0f27961 View commit details
    Browse the repository at this point in the history

  2. Simplify scripts/update_podfile_lock.sh 

    Since the packages/rn-tester provides a Gemfile, we can trust 'bundle
check' to do the validation.

While at that, use the 'bundle exec' execution to always use the
correct version.
    @barbieri
    barbieri committed Oct 1, 2021
    Configuration menu
    Copy the full SHA
    553fe9c View commit details
    Browse the repository at this point in the history

  3. NativeAnimatedHelper: Improve warning to use "bundle exec" 

    Since we're now providing a Gemfile, use "bundle exec" so we have the
user to get the correct versions when executing a command.
    @barbieri
    barbieri committed Oct 1, 2021
    Configuration menu
    Copy the full SHA
    e1d9cfa View commit details
    Browse the repository at this point in the history

  4. CircleCI uses our Gemfile 

    Let's use the specified CocoaPods and other gems in our Gemfile
instead of the system versions.

As documented at
https://circleci.com/docs/2.0/testing-ios/#using-custom-versions-of-cocoapods-and-other-ruby-gems
    @barbieri
    barbieri committed Oct 1, 2021
    Configuration menu
    Copy the full SHA
    202c69a View commit details
    Browse the repository at this point in the history

  5. Update all CocoaPods use to use "bundle exec" 

    This way we make sure the correct versions are in use.
    @barbieri
    barbieri committed Oct 1, 2021
    Configuration menu
    Copy the full SHA
    f047e06 View commit details
    Browse the repository at this point in the history

  6. Update Ruby version from bump-oss-version.js 

    Assume the system version is the latest and desired, update all
related files to use that version.

https://circleci.com/docs/2.0/testing-ios/#using-ruby states CircleCI
will use the latest stable version (2.7 at this moment), which is
excellent.
    @barbieri
    barbieri committed Oct 1, 2021
    Configuration menu
    Copy the full SHA
    bc0856b View commit details
    Browse the repository at this point in the history

  7. Shellcheck scripts/process-podspecs.sh 

    Fix all issues reported by https://github.com/koalaman/shellcheck
    @barbieri
    barbieri committed Oct 1, 2021
    Configuration menu
    Copy the full SHA
    1e2f819 View commit details
    Browse the repository at this point in the history