-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump @react-native/polyfills version #32074
Conversation
[Internal][Fixed] - Bump @react-native/polyfills facebook@8a62583 did some renaming inside of the @react-native/polyfills project, with the jest preset updated to the new name. The new package for polyfills has not yet been published, so the jest preset in the main branch will be looking for the new name, while the old name is provided. This is not hit inside the repo, since the dependency is linked instead of using the published one. Bump @react-native/polyfills to 2.0 (breaking change), in preparation for publish.
|
Base commit: a6768bf |
Base commit: a6768bf |
@yungsters has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
@NickGerleman, so I just read your PR summary more carefully and realized that 2.0.0 had not yet been published. I cannot merge this internally if it references packages that do not yet exist. This is because we have internal tests to verify that everything can be populated via an offline mirror (and other tests that verify everything can be installed and built). Is there a reason why you cannot publish 2.0.0 first? |
@hramos had asked that I create a PR for this so that he could publish. Some conversation in the Discord #releases channel |
Ah, okay. Let me follow up with @hramos. Thanks! |
I just published @react-native/[email protected] and scheduled a re-run of the failed Circle CI jobs. |
Awesome! Thank you for publishing. |
@yungsters merged this pull request in 2550948. |
Summary: 8a62583 did some renaming inside of the react-native/polyfills project, with the jest preset updated to use the new name. The new package for polyfills has not yet been published, so the jest preset in the main branch will be looking for the new name, while the old name is provided by the currently published react-native/[email protected]. This is not hit inside the repo, since the dependency is linked instead of using the published one. Bump react-native/polyfills to 2.0 (breaking change), in preparation for publish. ## Changelog [Internal][Fixed] - Bump react-native/polyfills version Pull Request resolved: #32074 Reviewed By: lunaleaps, cortinico Differential Revision: D30498104 Pulled By: yungsters fbshipit-source-id: 92dcb159d76bd74cd93cfa09e2155c9c1b2c0a86
Summary
8a62583 did some renaming inside of the @react-native/polyfills project, with the jest preset updated to use the new name. The new package for polyfills has not yet been published, so the jest preset in the main branch will be looking for the new name, while the old name is provided by the currently published @react-native/[email protected]. This is not hit inside the repo, since the dependency is linked instead of using the published one.
Bump @react-native/polyfills to 2.0 (breaking change), in preparation for publish.
Changelog
[Internal][Fixed] - Bump @react-native/polyfills version