Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @react-native/polyfills version #32074

Closed
wants to merge 1 commit into from

Conversation

NickGerleman
Copy link
Contributor

Summary

8a62583 did some renaming inside of the @react-native/polyfills project, with the jest preset updated to use the new name. The new package for polyfills has not yet been published, so the jest preset in the main branch will be looking for the new name, while the old name is provided by the currently published @react-native/[email protected]. This is not hit inside the repo, since the dependency is linked instead of using the published one.

Bump @react-native/polyfills to 2.0 (breaking change), in preparation for publish.

Changelog

[Internal][Fixed] - Bump @react-native/polyfills version

[Internal][Fixed] - Bump @react-native/polyfills

facebook@8a62583 did some renaming inside of the @react-native/polyfills project, with the jest preset updated to the new name. The new package for polyfills has not yet been published, so the jest preset in the main branch will be looking for the new name, while the old name is provided. This is not hit inside the repo, since the dependency is linked instead of using the published one.

Bump @react-native/polyfills to 2.0 (breaking change), in preparation for publish.
@NickGerleman NickGerleman requested a review from hramos as a code owner August 23, 2021 20:36
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Microsoft Partner: Microsoft Partner labels Aug 23, 2021
@pull-bot
Copy link

Warnings
⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.
Messages
📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against 5a6ea09

@analysis-bot
Copy link

analysis-bot commented Aug 23, 2021

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: a6768bf

@analysis-bot
Copy link

analysis-bot commented Aug 23, 2021

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 9,245,595 -641
android hermes armeabi-v7a 8,764,641 -1,157
android hermes x86 9,690,601 +1,731
android hermes x86_64 9,657,819 +937
android jsc arm64-v8a 10,881,797 -641
android jsc armeabi-v7a 9,792,111 -1,162
android jsc x86 10,922,219 +1,730
android jsc x86_64 11,530,938 +929

Base commit: a6768bf

@facebook-github-bot
Copy link
Contributor

@yungsters has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@yungsters
Copy link
Contributor

@NickGerleman, so I just read your PR summary more carefully and realized that 2.0.0 had not yet been published. I cannot merge this internally if it references packages that do not yet exist. This is because we have internal tests to verify that everything can be populated via an offline mirror (and other tests that verify everything can be installed and built).

Is there a reason why you cannot publish 2.0.0 first?

@NickGerleman
Copy link
Contributor Author

@NickGerleman, so I just read your PR summary more carefully and realized that 2.0.0 had not yet been published. I cannot merge this internally if it references packages that do not yet exist. This is because we have internal tests to verify that everything can be populated via an offline mirror (and other tests that verify everything can be installed and built).

Is there a reason why you cannot publish 2.0.0 first?

@hramos had asked that I create a PR for this so that he could publish. Some conversation in the Discord #releases channel

@yungsters
Copy link
Contributor

Ah, okay. Let me follow up with @hramos. Thanks!

@yungsters
Copy link
Contributor

I just published @react-native/[email protected] and scheduled a re-run of the failed Circle CI jobs.

@NickGerleman
Copy link
Contributor Author

Awesome! Thank you for publishing.

@facebook-github-bot
Copy link
Contributor

@yungsters merged this pull request in 2550948.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Aug 25, 2021
lunaleaps pushed a commit that referenced this pull request Aug 26, 2021
Summary:
8a62583 did some renaming inside of the react-native/polyfills project, with the jest preset updated to use the new name. The new package for polyfills has not yet been published, so the jest preset in the main branch will be looking for the new name, while the old name is provided by the currently published react-native/[email protected]. This is not hit inside the repo, since the dependency is linked instead of using the published one.

Bump react-native/polyfills to 2.0 (breaking change), in preparation for publish.

## Changelog

[Internal][Fixed] - Bump react-native/polyfills version

Pull Request resolved: #32074

Reviewed By: lunaleaps, cortinico

Differential Revision: D30498104

Pulled By: yungsters

fbshipit-source-id: 92dcb159d76bd74cd93cfa09e2155c9c1b2c0a86
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Microsoft Partner: Microsoft Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants