Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Update Swift version in Search Library Path #31912

Closed
wants to merge 1 commit into from

Conversation

Naturalclar
Copy link
Contributor

Summary

#29246

Currently, template project defaults to using Swift 5.0.

Some third-party react-native modules requires newer version of swift, such as react-native-menu/menu

This PR aims to update Swift version so users would not need to manually update it themselves

Changelog

[iOS] [Changed] - Update Swift Version to 5.3

Test Plan

  • RNTester builds properly
  • Third Party modules that requires newer swift version build correctly from template

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 27, 2021
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 9,178,699 +0
android hermes armeabi-v7a 8,703,753 +0
android hermes x86 9,621,621 +0
android hermes x86_64 9,587,192 +0
android jsc arm64-v8a 10,815,513 +0
android jsc armeabi-v7a 9,731,827 +0
android jsc x86 10,853,824 +0
android jsc x86_64 11,460,918 +0

Base commit: c2ba886

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants