Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump fresco to 2.5.0 #31699

Closed
wants to merge 2 commits into from
Closed

bump fresco to 2.5.0 #31699

wants to merge 2 commits into from

Conversation

dulmandakh
Copy link
Contributor

@dulmandakh dulmandakh commented Jun 10, 2021 •
edited
Loading

Summary

This PR bumps Fresco to 2.5.0, which is first version on MavenCentral since jCenter announcement.

Changelog

[Android] [Changed] - Bump Fresco to 2.5.0

Test Plan

CI is green

@facebook-github-bot facebook-github-bot added Contributor A React Native contributor. CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jun 10, 2021
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: b3a715f

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 9,213,123 -7,305
android hermes armeabi-v7a 8,712,120 -30,317
android hermes x86 9,663,909 -19,720
android hermes x86_64 9,631,767 -13,764
android jsc arm64-v8a 10,858,442 -8,622
android jsc armeabi-v7a 9,748,723 -31,632
android jsc x86 10,904,629 -21,039
android jsc x86_64 11,514,017 -15,076

Base commit: b3a715f

@dulmandakh dulmandakh mentioned this pull request Jun 10, 2021
Closed
@dulmandakh
Copy link
Contributor Author

@ShikaSD please review and merge

passy
passy approved these changes Jun 10, 2021
View reviewed changes
Copy link
Member

@passy passy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@facebook-github-bot
Copy link
Contributor

@passy has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@kelset kelset mentioned this pull request Jun 10, 2021
Closed
9 tasks
mweststrate pushed a commit to mweststrate/react-native that referenced this pull request Jun 11, 2021
@dulmandakh @facebook-github-bot
bump fresco to 2.5.0 (facebook#31699)
61afbac 
Summary:
This PR bumps Fresco to 2.5.0, which is first version on MavenCentral since jCenter announcement.

## Changelog

[Android] [Changed] - Bump Fresco to 2.5.0

Pull Request resolved: facebook#31699

Test Plan: CI is green

Differential Revision: D29031847

Pulled By: passy

fbshipit-source-id: c75753c07aa44ec8168f8d3d0f05cb43cceccbc2
@facebook-github-bot
Copy link
Contributor

@passy merged this pull request in 8fa8934.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jun 11, 2021
kelset pushed a commit that referenced this pull request Jun 16, 2021
@dulmandakh @kelset
bump fresco to 2.5.0 (#31699)
5f1d431 
Summary:
This PR bumps Fresco to 2.5.0, which is first version on MavenCentral since jCenter announcement.

## Changelog

[Android] [Changed] - Bump Fresco to 2.5.0

Pull Request resolved: #31699

Test Plan: CI is green

Reviewed By: TheSavior

Differential Revision: D29031847

Pulled By: passy

fbshipit-source-id: 486ffbf5461d07d736c0ebe17c0c7726937db344
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@passy passy passy approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. Merged This PR has been merged. Needs: React Native Team Attention
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dulmandakh @analysis-bot @facebook-github-bot @passy @kelset