-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed copying index.android.bundle with gradle 4.1 #31633
Conversation
Hi guys. I have many flavors and dependencies in project and when i call bundle<MyFlavor>Release - result aab file has built without index.android.bundle file This PR should fix copying index.android.bundle to intermediates assets dir with Android plugin 4.1+ currentBundleTask must run before currentAssetsCopyTask
Hi @Dimon70007! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
should fix #29398 |
duplicate of #30824 |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Base commit: 118489f |
tests failed
don't know how to fix it |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Any updates on this issue? I also ran into this issue where the Android build process attempts to copy the jsbundle before it is built. Can someone help take a look at the failed CircleCI tests? Thanks! |
I was getting an error on release builds when I was using:
so when I reverted it back to It worked perfectly fine. So I think this is great to go in at some point. Great work @Dimon70007 |
Thanks for your PR @Dimon70007 Feel free to re-open if you feel there is more to address here. |
Hi guys.
I have many flavors and dependencies in project and when i call bundleRelease - result aab file has built without index.android.bundle file
This PR should fix copying index.android.bundle to intermediates assets dir with Android plugin 4.1+
currentBundleTask must run before currentAssetsCopyTask
Summary
Changelog
[Android] [Fixed] - copying index.android.bundle to intermediates assets dir with Android plugin 4.1+. related #29398 #31157
Test Plan