Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed copying index.android.bundle with gradle 4.1 #31633

Closed
wants to merge 1 commit into from

Conversation

Dimon70007
Copy link

@Dimon70007 Dimon70007 commented May 30, 2021

Hi guys.
I have many flavors and dependencies in project and when i call bundleRelease - result aab file has built without index.android.bundle file
This PR should fix copying index.android.bundle to intermediates assets dir with Android plugin 4.1+
currentBundleTask must run before currentAssetsCopyTask

Summary

Changelog

[Android] [Fixed] - copying index.android.bundle to intermediates assets dir with Android plugin 4.1+. related #29398 #31157

Test Plan

Hi guys. 
I have many flavors and dependencies in project and when i call bundle<MyFlavor>Release - result aab file has built without index.android.bundle file
This PR should fix copying  index.android.bundle to intermediates assets dir with Android plugin 4.1+
currentBundleTask must run before currentAssetsCopyTask
@facebook-github-bot
Copy link
Contributor

Hi @Dimon70007!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@Dimon70007
Copy link
Author

should fix #29398

@Dimon70007
Copy link
Author

duplicate of #30824

@pull-bot
Copy link

Messages
📖

📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against 4cf86b2

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 30, 2021
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 118489f

@Dimon70007
Copy link
Author

Dimon70007 commented May 30, 2021

tests failed

error happened while trying to get dependency '//ReactAndroid/src/main/third-party/java/robolectric:robolectric'

don't know how to fix it

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@owjsub
Copy link
Contributor

owjsub commented Jul 27, 2021

Any updates on this issue? I also ran into this issue where the Android build process attempts to copy the jsbundle before it is built. Can someone help take a look at the failed CircleCI tests? Thanks!

@Manouli
Copy link

Manouli commented Jul 29, 2021

I was getting an error on release builds when I was using:

classpath("com.android.tools.build:gradle:4.1.0"

so when I reverted it back to classpath("com.android.tools.build:gradle:4.0.1"

It worked perfectly fine.

So I think this is great to go in at some point. Great work @Dimon70007

@cortinico
Copy link
Contributor

Thanks for your PR @Dimon70007
I'm closing as I realized that another PR that we merged already included the change you wanted to merge: #32026

Feel free to re-open if you feel there is more to address here.

@cortinico cortinico closed this Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants