-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing Flavors & App Bundle missing index.android.bundle with proguard enabled #31279
Conversation
This commit fixes Flavors & App Bundle missing index.android.bundle with proguard enabled facebook#31157 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
For reference, the failed test is unrelated to this PR. Let's get this merged! |
Base commit: 2e8893f |
@cortinico has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
@renopp head's up, your PR are being reviewed internally at FB. |
Thanks for your PR @renopp |
Base commit: 2e8893f |
Hi, @cortinico Thanks for the review I have rebase the PR and then the CI run has been green by now ✅ |
@cortinico has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
As a side note, we merged this last week #32026 that is introducing the line I mentioned in the comment. So I believe the issue is now fixed and we don't need to merge this PR anymore. |
Summary
This commit fixes Flavors & App Bundle missing index.android.bundle with proguard enabled
fixes #31157
Changelog
[Android] [Fixed] - Fixing Flavors & App Bundle missing index.android.bundle with proguard enabled
Test Plan
Manual
run
./gradlew clean
then./gradlew bundleRelease