Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Flavors & App Bundle missing index.android.bundle with proguard enabled #31279

Closed
wants to merge 2 commits into from

Conversation

renopp
Copy link

@renopp renopp commented Mar 31, 2021

Summary

This commit fixes Flavors & App Bundle missing index.android.bundle with proguard enabled
fixes #31157

Changelog

[Android] [Fixed] - Fixing Flavors & App Bundle missing index.android.bundle with proguard enabled

Test Plan

Manual
run ./gradlew clean then ./gradlew bundleRelease

This commit fixes Flavors & App Bundle missing index.android.bundle with proguard enabled facebook#31157 (comment)
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 31, 2021
@renopp
Copy link
Author

renopp commented Mar 31, 2021

@gedeagas

Copy link
Contributor

@gedeagas gedeagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davwheat
Copy link

davwheat commented Mar 31, 2021

For reference, the failed test is unrelated to this PR.

Let's get this merged!

@analysis-bot
Copy link

analysis-bot commented Mar 31, 2021

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 2e8893f

@renopp renopp closed this Mar 31, 2021
@renopp renopp reopened this Mar 31, 2021
@facebook-github-bot
Copy link
Contributor

@cortinico has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@gedeagas
Copy link
Contributor

@renopp head's up, your PR are being reviewed internally at FB.

@cortinico
Copy link
Contributor

Thanks for your PR @renopp
Can I ask you to rebase on top of main. The CI run is quite old and it should be green by now 👍

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,963,844 +0
android hermes armeabi-v7a 8,496,024 +0
android hermes x86 9,390,082 +0
android hermes x86_64 9,357,514 +0
android jsc arm64-v8a 10,627,986 +0
android jsc armeabi-v7a 9,549,339 +0
android jsc x86 10,641,227 +0
android jsc x86_64 11,252,374 +0

Base commit: 2e8893f

@renopp
Copy link
Author

renopp commented Aug 31, 2021

Hi, @cortinico Thanks for the review

I have rebase the PR and then the CI run has been green by now ✅

@facebook-github-bot
Copy link
Contributor

@cortinico has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@cortinico
Copy link
Contributor

As a side note, we merged this last week #32026 that is introducing the line I mentioned in the comment.

So I believe the issue is now fixed and we don't need to merge this PR anymore.
Can I ask you to verify that the issue is now solved on your end?

@renopp renopp closed this Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flavors & App Bundle missing index.android.bundle with proguard enabled
6 participants