-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(iOS): added lineBreakStrategy attribute to Text/TextInput #31272
Conversation
7d77744
to
29dc411
Compare
Base commit: 68f3fb2 |
67a0cee
to
635d68b
Compare
Base commit: 7f1729a |
1450a82
to
86a6704
Compare
86a6704
to
4a91858
Compare
Any updates on this? |
66d2ce9
to
c725c30
Compare
Hi @lunaleaps , Is there anything else I can do help for this PR get merged? |
c725c30
to
7df6975
Compare
|
Sorry for the delayed reply here, let me import and ask around. I think my concern might be that prop name and the iOS specificity of it. |
@lunaleaps has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Hi @lunaleaps, thanks for the reply! e.g. https://reactnative.dev/docs/0.69/text#android_hyphenationfrequency-android Please let me know if need to change the prop name, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bang9 for these changes!
Is it also possible to run the linter on this? I believe yarn run clang-format
might be it?
Thanks!
@lunaleaps Is it okay to commit? I ran the |
Strange.. that's good to know! I can run our internal formatter then, thanks for letting me know |
@lunaleaps has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
5a1939b
to
5fe3fa1
Compare
@lunaleaps has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This pull request was successfully merged by @bang9 in 0481948. When will my fix make it into a release? | Upcoming Releases |
Hello, is there any plan to backport this into previous versions? For CJK users this feels like a crucial feature to have. |
…ook#31272) Summary: iOS did not support the implementation of Korean word-wrap(line-break) before iOS14. If the attribute applied, the word-wrap of Korean will works. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [iOS] [Added] - Line break strategy for Text and TextInput components Pull Request resolved: facebook#31272 Test Plan: 1. Test build and run on above iOS 14. 2. Test it does not affect existing text components when set default(none) strategy. 3. Test whether word-wrap works with Korean when set hangul-word strategy. <img src="https://user-images.githubusercontent.com/26326015/112963967-d7f70c00-9182-11eb-9a34-8c758b80c219.png" width="300" height="" style="max-width:100%;"> Reviewed By: javache Differential Revision: D39824809 Pulled By: lunaleaps fbshipit-source-id: 42cb0385221a38c84e80d3494d1bfc1934ecf32b
Summary
iOS did not support the implementation of Korean word-wrap(line-break) before iOS14.
If the attribute applied, the word-wrap of Korean will works.
Changelog
[iOS] [Added] - Line break strategy for Text and TextInput components
Test Plan