-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add modal example #30406
Add modal example #30406
Conversation
|
Base commit: 68a4761 |
Base commit: 68a4761 |
@rickhanlonii The only failing test is test_ios_unit_frameworks_hermes which was failing on master! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rickhanlonii has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Thanks for working on this :) Just checking, did you test on iOS as well? (since the diff makes some iOS specific changes, and I don't see that in your test plan) |
@PeteTheHeat Yup, I've tested it on iOS as well. |
This pull request was successfully merged by @suminkimm in 8dddaa8. When will my fix make it into a release? | Upcoming Releases |
Summary
Add examples for Modal component in RNTester for:
Changelog
[General] [Add] - Added examples for Modal component in RNTester
Test Plan