Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default color for ActivityIndicator on Android #30057

Closed

Conversation

jayshah123
Copy link
Contributor

Summary

ActivityIndicator is blank after RN 0.63, and does not show up unless explicit color prop is provided.

Fixes #30056,
#29495, #29378

Fix By using PlatformColor API to set default platform color which is according to https://developer.android.com/reference/android/R.attr#colorControlActivated

Before fix:
Screenshot_20200928-220924_RNTester App

After fix:
Screenshot_20200928-221153_RNTester App

Changelog

[Android] [Fixed] - Show default platform color for Android ActivityIndicator when no color supplied in prop.

Test Plan

Go to AppTester App > ActivityIndicator > Android Activity indicator should be seen with default platform color.

@react-native-bot react-native-bot added Bug Platform: Android Android applications. labels Sep 28, 2020
@analysis-bot
Copy link

analysis-bot commented Sep 28, 2020

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,371,241 744
android hermes armeabi-v7a 6,998,313 736
android hermes x86 7,811,741 740
android hermes x86_64 7,703,291 736
android jsc arm64-v8a 9,516,278 460
android jsc armeabi-v7a 9,135,490 452
android jsc x86 9,382,362 456
android jsc x86_64 9,963,276 460

Base commit: 2160377

@analysis-bot
Copy link

analysis-bot commented Sep 28, 2020

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 2160377

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 28, 2020
@jayshah123
Copy link
Contributor Author

Is there a way to request a review from someone in the RN team?

@hank121314
Copy link
Contributor

Hi @Simek .
I think this issue is related to #29717 and should be fixed by #29830 .
All of the situation show that if color props is null. Android text or activityIndicator will disappear(transparent).
I think pr #29830 will be a universal fix.

@jayshah123
Copy link
Contributor Author

#29717

Will try to check your fork.

flochtililoch pushed a commit to Instawork/hyperview that referenced this pull request May 17, 2021
React Native 0.63 does not have a default color for `ActivityIndicator` on Android. See [related PR](facebook/react-native#30057).
@taylorkline
Copy link

Thanks, I am integrating this patch with yarn patch-package and it works for me on 0.64.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Platform: Android Android applications.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ActivityIndicator works only on iOS
8 participants