-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default color for ActivityIndicator on Android #30057
Closed
jayshah123
wants to merge
4
commits into
facebook:main
from
jayshah123:fix/android-activityindicator
Closed
Default color for ActivityIndicator on Android #30057
jayshah123
wants to merge
4
commits into
facebook:main
from
jayshah123:fix/android-activityindicator
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base commit: 2160377 |
Base commit: 2160377 |
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Sep 28, 2020
Simek
reviewed
Sep 28, 2020
Is there a way to request a review from someone in the RN team? |
Will try to check your fork. |
flochtililoch
pushed a commit
to Instawork/hyperview
that referenced
this pull request
May 17, 2021
React Native 0.63 does not have a default color for `ActivityIndicator` on Android. See [related PR](facebook/react-native#30057).
Thanks, I am integrating this patch with |
facuhump2409
approved these changes
Jul 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Bug
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Platform: Android
Android applications.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ActivityIndicator is blank after RN 0.63, and does not show up unless explicit
color
prop is provided.Fixes #30056,
#29495, #29378
Fix By using
PlatformColor
API to set default platform color which is according to https://developer.android.com/reference/android/R.attr#colorControlActivatedBefore fix:
After fix:
Changelog
[Android] [Fixed] - Show default platform color for Android ActivityIndicator when no color supplied in prop.
Test Plan
Go to AppTester App > ActivityIndicator > Android Activity indicator should be seen with default platform color.