-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] fix DPAD scrolling scrollView even when scrollEnabled is set to false #29906
Conversation
Hi @TheDuc! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Base commit: 7e89934 |
Base commit: 7e89934 |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
@ermanzohre @gedeagas Any update on this? |
@ermanzohre @cpojer @shergin @hramos @mhorowitz @gedeagas any update on this? |
This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
This PR was closed because it has been stalled for 7 days with no activity. |
Summary
#29774
Fixes scrollView behaviour on DPAD input when scrollEnabled is set to false
Changelog
[Android] [Fixed] - fix DPAD scrolling scrollView even when scrollEnabled is set to false