Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] fix DPAD scrolling scrollView even when scrollEnabled is set to false #29906

Closed
wants to merge 2 commits into from

Conversation

TheDuc
Copy link

@TheDuc TheDuc commented Sep 9, 2020

Summary

#29774
Fixes scrollView behaviour on DPAD input when scrollEnabled is set to false

Changelog

[Android] [Fixed] - fix DPAD scrolling scrollView even when scrollEnabled is set to false

@facebook-github-bot
Copy link
Contributor

Hi @TheDuc!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@TheDuc TheDuc changed the base branch from master to 0.61-stable September 9, 2020 09:49
@TheDuc TheDuc changed the base branch from 0.61-stable to 0.63-stable September 9, 2020 09:49
@pull-bot
Copy link

pull-bot commented Sep 9, 2020

Warnings
⚠️

❔ Base Branch - The base branch for this PR is something other than master. Are you sure you want to merge these changes into a stable release? If you are interested in backporting updates to an older release, the suggested approach is to land those changes on master first and then cherry-pick the commits into the branch for that release. The Releases Guide has more information.

⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.
Messages
📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against 04cb1b3

@TheDuc TheDuc changed the base branch from 0.63-stable to master September 9, 2020 09:51
@react-native-bot react-native-bot added Bug Platform: Android Android applications. labels Sep 9, 2020
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 7e89934

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 9, 2020
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,209,449 28
android hermes armeabi-v7a 6,858,621 28
android hermes x86 7,644,081 12
android hermes x86_64 7,535,025 16
android jsc arm64-v8a 9,369,066 8
android jsc armeabi-v7a 9,010,382 20
android jsc x86 9,231,802 20
android jsc x86_64 9,808,942 24

Base commit: 7e89934

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@TheDuc
Copy link
Author

TheDuc commented Oct 7, 2020

@ermanzohre @gedeagas Any update on this?

@TheDuc
Copy link
Author

TheDuc commented Nov 4, 2020

@ermanzohre @cpojer @shergin @hramos @mhorowitz @gedeagas any update on this?

@github-actions
Copy link

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Jul 12, 2023
@github-actions
Copy link

This PR was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Platform: Android Android applications. Stale There has been a lack of activity on this issue and it may be closed soon.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants